Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix layernorm cpu precision issues #108089

Closed
wants to merge 3 commits into from
Closed

Fix layernorm cpu precision issues #108089

wants to merge 3 commits into from

Conversation

mikaylagawarecki
Copy link
Contributor

@mikaylagawarecki mikaylagawarecki commented Aug 28, 2023 •
edited

@pytorch-bot
Copy link

pytorch-bot bot commented Aug 28, 2023 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/108089

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 2 Pending

As of commit 7505ac9 with merge base dcc674d (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

mikaylagawarecki added a commit that referenced this pull request Aug 28, 2023
@mikaylagawarecki
[Testing] Fix layernorm cpu precision issues
71d9f48 
ghstack-source-id: 62793e0c762d749e1e7bde11058057f33ad2a0cd
Pull Request resolved: #108089
@github-actions github-actions bot added the module: cpu CPU specific problem (e.g., perf, algorithm) label Aug 28, 2023
@mikaylagawarecki
Update on "[Testing] Fix layernorm cpu precision issues"
93dbbc5 
#108072




cc jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10

[ghstack-poisoned]
mikaylagawarecki added a commit that referenced this pull request Aug 28, 2023
@mikaylagawarecki
[Testing] Fix layernorm cpu precision issues
0fba3f8 
ghstack-source-id: 0d45d2c59f6d91eba870701e8516aaf701b7fead
Pull Request resolved: #108089
@mingfeima mingfeima marked this pull request as ready for review August 29, 2023 07:49
@mingfeima
Copy link
Collaborator

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Aug 29, 2023
@mingfeima
Copy link
Collaborator

@mikaylagawarecki nice work !

@XiaobingSuper
Copy link
Collaborator

@mikaylagawarecki, could you help cherry-pick this PR for 2.1 branch? see #108055. Thanks!

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: This PR needs a release notes: label
If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Details for Dev Infra team Raised by workflow job

@XiaobingSuper XiaobingSuper changed the title [Testing] Fix layernorm cpu precision issues Fix layernorm cpu precision issues Aug 29, 2023
@XiaobingSuper XiaobingSuper added the topic: not user facing topic category label Aug 29, 2023
albanD
albanD approved these changes Aug 29, 2023
View reviewed changes
Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM
Could you add a test to make sure we preserve this behavior properly going forward please?

@mikaylagawarecki
Update on "Fix layernorm cpu precision issues"
7505ac9 
#108072




cc jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10

[ghstack-poisoned]
mikaylagawarecki added a commit that referenced this pull request Aug 30, 2023
@mikaylagawarecki
[Testing] Fix layernorm cpu precision issues
7d153b9 
ghstack-source-id: 5913a3c505050eb3280e7f41e1db2763de656fd5
Pull Request resolved: #108089
@mikaylagawarecki
Copy link
Contributor Author

@XiaobingSuper I don't think this meets the criteria as a critical fix, so unfortunately we can't cherry pick this

@mikaylagawarecki
Copy link
Contributor Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@mikaylagawarecki mikaylagawarecki mentioned this pull request Aug 31, 2023
Closed
@facebook-github-bot facebook-github-bot deleted the gh/mikaylagawarecki/150/head branch September 3, 2023 14:24
This was referenced Sep 9, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albanD albanD albanD approved these changes

@mingfeima mingfeima mingfeima approved these changes

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged module: cpu CPU specific problem (e.g., perf, algorithm) topic: not user facing topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mikaylagawarecki @mingfeima @XiaobingSuper @pytorchmergebot @albanD