New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check results dtype in index_out #108167
Check results dtype in index_out #108167
Conversation
This logic exists for index_put and index_add, but for some reason not for index_get Fixes #107698
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/108167
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit c688cfd with merge base 78810d7 (): This comment was automatically generated by Dr. CI and updates every 15 minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with no.
We can have test for this when we move the Executorch out variant OpInfos into core!
@pytorchbot merge |
Merge failedReason: This PR needs a If not, please add the To add a label, you can comment to pytorchbot, for example For more information, see Details for Dev Infra teamRaised by workflow job |
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
This logic exists for index_put and index_add, but for some reason not for
index.out
Skip testing, as this function is not technically exposed on the Python level.
🤖 Generated by Copilot at c688cfd
Fixes #107698