Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check results dtype in index_out #108167

Closed
wants to merge 2 commits into from
Closed

Check results dtype in index_out #108167

wants to merge 2 commits into from

Conversation

malfet
Copy link
Contributor

@malfet malfet commented Aug 29, 2023

This logic exists for index_put and index_add, but for some reason not for index.out
Skip testing, as this function is not technically exposed on the Python level.

🤖 Generated by Copilot at c688cfd

index_out checks types
avoiding errors in autumn
complex tensors work

Fixes #107698

This logic exists for index_put and index_add, but for some reason not for index_get

Fixes #107698
@malfet malfet requested a review from albanD August 29, 2023 17:23
@pytorch-bot
Copy link

pytorch-bot bot commented Aug 29, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/108167

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit c688cfd with merge base 78810d7 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with no.
We can have test for this when we move the Executorch out variant OpInfos into core!

@malfet malfet added the topic: not user facing topic category label Aug 29, 2023
@malfet malfet added topic: bug fixes topic category ciflow/trunk Trigger trunk jobs on your pull request and removed topic: not user facing topic category labels Aug 29, 2023
@malfet
Copy link
Contributor Author

malfet commented Aug 30, 2023

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: This PR needs a release notes: label
If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Details for Dev Infra team Raised by workflow job

@malfet malfet added the release notes: cpp release notes category label Aug 30, 2023
@malfet
Copy link
Contributor Author

malfet commented Aug 30, 2023

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@malfet malfet deleted the malfet-patch-16 branch October 18, 2023 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: cpp release notes category topic: bug fixes topic category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

index.Tensor_out doesn't properly handle dtype conversions
3 participants