Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add examples for nn.CosineEmbeddingLoss #108215

Closed
wants to merge 3 commits into from
Closed

Add examples for nn.CosineEmbeddingLoss #108215

wants to merge 3 commits into from

Conversation

minhlong94
Copy link
Contributor

No description provided.

@pytorch-bot
Copy link

pytorch-bot bot commented Aug 30, 2023 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/108215

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit e9b6de8 with merge base 3a79621 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@colesbury colesbury added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Aug 30, 2023
@albanD albanD removed their request for review August 30, 2023 14:48
@mikaylagawarecki mikaylagawarecki added release notes: nn release notes category topic: docs topic category labels Aug 30, 2023
mikaylagawarecki
mikaylagawarecki reviewed Aug 30, 2023
View reviewed changes
Copy link
Contributor

@mikaylagawarecki mikaylagawarecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good other than one nit.

To fix the failing lint job running make setup_lint and make quicklint from your local pytorch directory and following the corresponding instructions should be sufficient, see here

torch/nn/modules/loss.py Outdated Show resolved Hide resolved
@minhlong94
Copy link
Contributor Author

Hi @mikaylagawarecki , can you show me the instructions to do that? I am still new to the contribution process.

mikaylagawarecki
mikaylagawarecki approved these changes Aug 31, 2023
View reviewed changes
Copy link
Contributor

@mikaylagawarecki mikaylagawarecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you figured the lint out, thanks!

@mikaylagawarecki
Copy link
Contributor

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Aug 31, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikaylagawarecki mikaylagawarecki mikaylagawarecki approved these changes

@jbschlosser jbschlosser Awaiting requested review from jbschlosser jbschlosser is a code owner

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged open source release notes: nn release notes category topic: docs topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@minhlong94 @mikaylagawarecki @pytorchmergebot @colesbury @pytorchbot