New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add examples for nn.CosineEmbeddingLoss
#108215
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/108215
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit e9b6de8 with merge base 3a79621 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good other than one nit.
To fix the failing lint job running make setup_lint
and make quicklint
from your local pytorch directory and following the corresponding instructions should be sufficient, see here
Hi @mikaylagawarecki , can you show me the instructions to do that? I am still new to the contribution process. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like you figured the lint out, thanks!
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
No description provided.