Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dtensor][6/n] refactor reduction to use op strategy #108264

Closed
wants to merge 4 commits into from

Conversation

wanchaol
Copy link
Contributor

@wanchaol wanchaol commented Aug 30, 2023

This PR refactors the reduction op to use strategy based propagation

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Aug 30, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/108264

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 3809440 with merge base 71b4b32 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

This PR refactors the reduction op to use strategy based propagation

[ghstack-poisoned]
@wanchaol wanchaol added the release notes: distributed (dtensor) release notes category label Aug 30, 2023
This PR refactors the reduction op to use strategy based propagation

[ghstack-poisoned]
Copy link
Contributor

@fduwjj fduwjj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

torch/distributed/_tensor/ops/math_ops.py Outdated Show resolved Hide resolved
This PR refactors the reduction op to use strategy based propagation

[ghstack-poisoned]
pytorchmergebot pushed a commit that referenced this pull request Sep 26, 2023
Pull Request resolved: #109144
Approved by: https://github.com/fduwjj
ghstack dependencies: #108263, #108264
@facebook-github-bot facebook-github-bot deleted the gh/wanchaol/353/head branch September 30, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants