-
Notifications
You must be signed in to change notification settings - Fork 21.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dtensor][6/n] refactor reduction to use op strategy #108264
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR refactors the reduction op to use strategy based propagation [ghstack-poisoned]
This was referenced Aug 30, 2023
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/108264
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 3809440 with merge base 71b4b32 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR refactors the reduction op to use strategy based propagation [ghstack-poisoned]
This PR refactors the reduction op to use strategy based propagation [ghstack-poisoned]
This was referenced Sep 12, 2023
fduwjj
approved these changes
Sep 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR refactors the reduction op to use strategy based propagation [ghstack-poisoned]
pytorchmergebot
pushed a commit
that referenced
this pull request
Sep 26, 2023
Pull Request resolved: #109144 Approved by: https://github.com/fduwjj ghstack dependencies: #108263, #108264
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This PR refactors the reduction op to use strategy based propagation