Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for symbolic repeat_interleave #108763

Closed
wants to merge 3 commits into from
Closed

Add support for symbolic repeat_interleave #108763

wants to merge 3 commits into from

Conversation

ezyang
Copy link
Contributor

@ezyang ezyang commented Sep 7, 2023 •
edited
Loading

Stack from ghstack (oldest at bottom):

Fixes #108195

Signed-off-by: Edward Z. Yang ezyang@meta.com

@ezyang
Add support for symbolic repeat_interleave
0c17c0d 
Signed-off-by: Edward Z. Yang <ezyang@meta.com>

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Sep 7, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/108763

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ You can merge normally! (2 Unrelated Failures)

As of commit e93f7bf with merge base 121cfb6 (image):

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

ezyang added a commit that referenced this pull request Sep 7, 2023
@ezyang
Add support for symbolic repeat_interleave
1f6804c 
Signed-off-by: Edward Z. Yang <ezyangmeta.com>

ghstack-source-id: 7d1d910135047e62dffa8fa46523af43003ecae3
Pull Request resolved: #108763
@ezyang
Update on "Add support for symbolic repeat_interleave"
acbba6d 
Signed-off-by: Edward Z. Yang <ezyangmeta.com>

[ghstack-poisoned]
ezyang added a commit that referenced this pull request Sep 7, 2023
@ezyang
Add support for symbolic repeat_interleave
788f39b 
Signed-off-by: Edward Z. Yang <ezyangmeta.com>

ghstack-source-id: becde8f8510f91c22bd756ace3bd88fdb629d332
Pull Request resolved: #108763
@ezyang
Update on "Add support for symbolic repeat_interleave"
e93f7bf 
Signed-off-by: Edward Z. Yang <ezyangmeta.com>

[ghstack-poisoned]
ezyang added a commit that referenced this pull request Sep 7, 2023
@ezyang
Add support for symbolic repeat_interleave
5648c9b 
Signed-off-by: Edward Z. Yang <ezyangmeta.com>

ghstack-source-id: 25c3d78bbd6dda7a6978e7f74054b66966f12254
Pull Request resolved: #108763
@ezyang ezyang added the ciflow/trunk Trigger trunk jobs on your pull request label Sep 8, 2023
@ezyang
Copy link
Contributor Author

ezyang commented Sep 8, 2023

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: This PR needs a release notes: label
If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Details for Dev Infra team Raised by workflow job

@ezyang ezyang added release notes: composability release notes category topic: new features topic category labels Sep 8, 2023
@ezyang
Copy link
Contributor Author

ezyang commented Sep 8, 2023

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

eellison
eellison reviewed Sep 8, 2023
View reviewed changes
torch/_subclasses/fake_tensor.py

output_size = fake_mode.shape_env.create_unbacked_symint()
constrain_range(output_size, min=2, max=sys.maxsize - 1)
# TODO: consider a memo
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we registered a decomp for this, the memo would come for free

@facebook-github-bot facebook-github-bot deleted the gh/ezyang/2327/head branch September 12, 2023 14:23
@airalcorn2 airalcorn2 mentioned this pull request Apr 12, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eellison eellison eellison left review comments

@Chillee Chillee Chillee approved these changes

@albanD albanD Awaiting requested review from albanD

@antoniojkim antoniojkim Awaiting requested review from antoniojkim

@bdhirsh bdhirsh Awaiting requested review from bdhirsh

@miladm miladm Awaiting requested review from miladm

@SherlockNoMad SherlockNoMad Awaiting requested review from SherlockNoMad

@voznesenskym voznesenskym Awaiting requested review from voznesenskym

@wconstab wconstab Awaiting requested review from wconstab

Assignees
No one assigned
Labels
ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: composability release notes category topic: new features topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ezyang @pytorchmergebot @Chillee @eellison