Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated pad_sequence type hint #108765

Closed
wants to merge 3 commits into from
Closed

updated pad_sequence type hint #108765

wants to merge 3 commits into from

Conversation

randolf-scholz
Copy link
Contributor

@randolf-scholz randolf-scholz commented Sep 7, 2023 •
edited by pytorch-bot bot

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 7, 2023 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/108765

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ You can merge normally! (1 Unrelated Failure)

As of commit e1125ac with merge base b193f29 (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Sep 7, 2023 •
edited

CLA Signed

The committers listed above are authorized under a signed CLA.

@randolf-scholz randolf-scholz reopened this Sep 7, 2023
@randolf-scholz
Copy link
Contributor Author

@zou3519 Better late than never. Can you also have a look at #108767?

@randolf-scholz
Copy link
Contributor Author

@pytorchbot label "module: typing"

@pytorch-bot pytorch-bot bot added the module: typing Related to mypy type annotations label Sep 7, 2023
malfet
malfet approved these changes Sep 7, 2023
View reviewed changes
Copy link
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix

@randolf-scholz
Copy link
Contributor Author

@pytorchbot label "release notes: nn"

@pytorch-bot pytorch-bot bot added the release notes: nn release notes category label Sep 7, 2023
@ezyang
Copy link
Contributor

ezyang commented Sep 8, 2023

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Sep 8, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@randolf-scholz
Copy link
Contributor Author

Seems like a server failure: https://github.com/pytorch/pytorch/actions/runs/6111015232/job/16596880143#step:11:6007

@ezyang
Copy link
Contributor

ezyang commented Sep 8, 2023

@pytorchbot merge -i

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged while ignoring the following 1 checks: pull / linux-docs / build-docs-python-false

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@randolf-scholz randolf-scholz deleted the pad_sequence_hint branch September 8, 2023 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ezyang ezyang ezyang approved these changes

@malfet malfet malfet approved these changes

@zou3519 zou3519 zou3519 approved these changes

@albanD albanD Awaiting requested review from albanD albanD is a code owner

@jbschlosser jbschlosser Awaiting requested review from jbschlosser jbschlosser is a code owner

@mikaylagawarecki mikaylagawarecki Awaiting requested review from mikaylagawarecki mikaylagawarecki is a code owner

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged module: typing Related to mypy type annotations open source release notes: nn release notes category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[typing] torch.nn.utils.rnn.pad_sequence has too strict type hint.
6 participants
@randolf-scholz @ezyang @pytorchmergebot @malfet @zou3519 @pytorchbot