Check index size during decomp of index_add #108826
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This partially fixes the `test_index_add_correctness` test (#108181) when run under inductor: it causes an exception to be raised [here](https://github.com/pytorch/pytorch/blob/dec2b267d4af159bd0a8669a679700f385a1dc98/test/test_torch.py#L6049) as expected. The test as a whole still cannot be made to pass under inductor because the [last assert](https://github.com/pytorch/pytorch/blob/dec2b267d4af159bd0a8669a679700f385a1dc98/test/test_torch.py#L6051) still fails, likely due to #108798. [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/108826
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (2 Unrelated Failures)As of commit 70e8f9d with merge base e066056 ( BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
int3
added a commit
that referenced
this pull request
Sep 8, 2023
This partially fixes the `test_index_add_correctness` test (#108181) when run under inductor: it causes an exception to be raised [here](https://github.com/pytorch/pytorch/blob/dec2b267d4af159bd0a8669a679700f385a1dc98/test/test_torch.py#L6049) as expected. The test as a whole still cannot be made to pass under inductor because the [last assert](https://github.com/pytorch/pytorch/blob/dec2b267d4af159bd0a8669a679700f385a1dc98/test/test_torch.py#L6051) still fails, likely due to #108798. ghstack-source-id: 76d65e928c590f67d6648115289b737e49a47fc5 Pull Request resolved: #108826
This partially fixes the `test_index_add_correctness` test (#108181) when run under inductor: it causes an exception to be raised [here][1] as expected. The test as a whole still cannot be made to pass under inductor because the [last assert][2] still fails, likely due to #108798. [1]: https://github.com/pytorch/pytorch/blob/dec2b267d4af159bd0a8669a679700f385a1dc98/test/test_torch.py#L6049 [2]: https://github.com/pytorch/pytorch/blob/dec2b267d4af159bd0a8669a679700f385a1dc98/test/test_torch.py#L6051 [ghstack-poisoned]
int3
added a commit
that referenced
this pull request
Sep 8, 2023
This partially fixes the `test_index_add_correctness` test (#108181) when run under inductor: it causes an exception to be raised [here](https://github.com/pytorch/pytorch/blob/dec2b267d4af159bd0a8669a679700f385a1dc98/test/test_torch.py#L6049) as expected. The test as a whole still cannot be made to pass under inductor because the [last assert](https://github.com/pytorch/pytorch/blob/dec2b267d4af159bd0a8669a679700f385a1dc98/test/test_torch.py#L6051) still fails, likely due to #108798. ghstack-source-id: 3eb59e494cb4d7518b8192f90ff5c471512d56bf Pull Request resolved: #108826
This partially fixes the `test_index_add_correctness` test (#108181) when run under inductor: it causes an exception to be raised [here][1] as expected. The test as a whole still cannot be made to pass under inductor because the [last assert][2] still fails, likely due to #108798. [1]: https://github.com/pytorch/pytorch/blob/dec2b267d4af159bd0a8669a679700f385a1dc98/test/test_torch.py#L6049 [2]: https://github.com/pytorch/pytorch/blob/dec2b267d4af159bd0a8669a679700f385a1dc98/test/test_torch.py#L6051 [ghstack-poisoned]
int3
added a commit
that referenced
this pull request
Sep 9, 2023
This partially fixes the `test_index_add_correctness` test (#108181) when run under inductor: it causes an exception to be raised [here](https://github.com/pytorch/pytorch/blob/dec2b267d4af159bd0a8669a679700f385a1dc98/test/test_torch.py#L6049) as expected. The test as a whole still cannot be made to pass under inductor because the [last assert](https://github.com/pytorch/pytorch/blob/dec2b267d4af159bd0a8669a679700f385a1dc98/test/test_torch.py#L6051) still fails, likely due to #108798. ghstack-source-id: c3d16b14ea0392ea4481e56696904ddfdbe87aa3 Pull Request resolved: #108826
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 2 jobs have failed, first few of them are: trunk / linux-focal-cuda12.1-py3.10-gcc9 / test (nogpu_AVX512, 1, 1, linux.2xlarge), trunk / linux-focal-cuda12.1-py3.10-gcc9 / test (nogpu_NO_AVX2, 1, 1, linux.2xlarge) Details for Dev Infra teamRaised by workflow job |
This partially fixes the `test_index_add_correctness` test (#108181) when run under inductor: it causes an exception to be raised [here][1] as expected. The test as a whole still cannot be made to pass under inductor because the [last assert][2] still fails, likely due to #108798. [1]: https://github.com/pytorch/pytorch/blob/dec2b267d4af159bd0a8669a679700f385a1dc98/test/test_torch.py#L6049 [2]: https://github.com/pytorch/pytorch/blob/dec2b267d4af159bd0a8669a679700f385a1dc98/test/test_torch.py#L6051 [ghstack-poisoned]
int3
added a commit
that referenced
this pull request
Sep 13, 2023
This partially fixes the `test_index_add_correctness` test (#108181) when run under inductor: it causes an exception to be raised [here](https://github.com/pytorch/pytorch/blob/dec2b267d4af159bd0a8669a679700f385a1dc98/test/test_torch.py#L6049) as expected. The test as a whole still cannot be made to pass under inductor because the [last assert](https://github.com/pytorch/pytorch/blob/dec2b267d4af159bd0a8669a679700f385a1dc98/test/test_torch.py#L6051) still fails, likely due to #108798. ghstack-source-id: 623be2a1157b84ef44c5769a3feb69ab441bc384 Pull Request resolved: #108826
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
The merge job was canceled. If you believe this is a mistake, then you can re trigger it through pytorch-bot. |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This partially fixes the
test_index_add_correctnesstest (#108181)when run under inductor: it causes an exception to be raised here
as expected.
The test as a whole still cannot be made to pass under inductor because
the last assert still fails, likely due to #108798.