Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add checks to num_layers for RNN, LSTM, GRU #108853

Closed
wants to merge 2 commits into from
Closed

Add checks to num_layers for RNN, LSTM, GRU #108853

wants to merge 2 commits into from

Conversation

FFFrog
Copy link
Collaborator

@FFFrog FFFrog commented Sep 8, 2023

Fixes #108223

As the title shown

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 8, 2023 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/108853

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ No Failures

As of commit 4db5d96 with merge base b193f29 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: cpp release notes category label Sep 8, 2023
@FFFrog
Copy link
Collaborator Author

FFFrog commented Sep 8, 2023

@albanD, @mikaylagawarecki , please have a look at this, thank you.

@zou3519 zou3519 added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Sep 8, 2023
@mikaylagawarecki mikaylagawarecki changed the title fix the issue described by #108223 Add checks to num_layers for RNN, LSTM, GRU CPP API Sep 8, 2023
@mikaylagawarecki mikaylagawarecki changed the title Add checks to num_layers for RNN, LSTM, GRU CPP API Add checks to num_layers for RNN, LSTM, GRU C++ API Sep 8, 2023
@mikaylagawarecki mikaylagawarecki changed the title Add checks to num_layers for RNN, LSTM, GRU C++ API Add checks to num_layers for RNN, LSTM, GRU Sep 8, 2023
mikaylagawarecki
mikaylagawarecki approved these changes Sep 8, 2023
View reviewed changes
Copy link
Contributor

@mikaylagawarecki mikaylagawarecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Sep 8, 2023
@pytorch pytorch deleted a comment from pytorchmergebot Sep 8, 2023
@pytorch pytorch deleted a comment from pytorchmergebot Sep 8, 2023
@FFFrog
Copy link
Collaborator Author

FFFrog commented Sep 9, 2023

@pytorchbot merge -i

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged while ignoring the following 0 checks:

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@FFFrog FFFrog deleted the mrl_fix_gru branch September 11, 2023 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikaylagawarecki mikaylagawarecki mikaylagawarecki approved these changes

@albanD albanD Awaiting requested review from albanD albanD is a code owner

@jbschlosser jbschlosser Awaiting requested review from jbschlosser jbschlosser is a code owner

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged open source release notes: cpp release notes category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

C++ API RNN modules(RNN, LSTM, GRU) crash by segfault with num_layers <= 0
5 participants
@FFFrog @pytorchmergebot @mikaylagawarecki @zou3519 @pytorchbot