Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DTensor] Remove compute_local_offset from _utils.py and replace current usage with new API #108965

Closed
wants to merge 1 commit into from
Closed

[DTensor] Remove compute_local_offset from _utils.py and replace current usage with new API #108965

wants to merge 1 commit into from

Conversation

wz337
Copy link
Contributor

@wz337 wz337 commented Sep 10, 2023

Summary:
This diff:

  • Remove compute_local_offset from _utils.py
  • Replace current usage with new API compute_local_shape_and_global_offset.

More context of why we introduced the new API:
#108547

Test Plan: CI

Differential Revision: D49130050

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 10, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/108965

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (3 Unrelated Failures)

As of commit 393b9c6 with merge base 3b265e0 (image):

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

UNSTABLE - The following job failed but was likely due to flakiness present on trunk and has been marked as unstable:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Sep 10, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: wz337 / name: Iris Z (393b9c6)

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49130050

@wz337 wz337 added the topic: not user facing topic category label Sep 10, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49130050

@wz337 @facebook-github-bot
[DTensor] Remove compute_local_offset from _utils.py and replace curr…
393b9c6 
…ent usage with new API (pytorch#108965)

Summary:

This diff:
- Remove compute_local_offset from _utils.py
- Replace current usage with new API compute_local_shape_and_global_offset.

More context of why we introduced the new API:
pytorch#108547

Test Plan: CI

Differential Revision: D49130050
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49130050

fduwjj
fduwjj approved these changes Sep 11, 2023
View reviewed changes
Copy link
Contributor

@fduwjj fduwjj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for cleaning this up.

@fduwjj
Copy link
Contributor

fduwjj commented Sep 11, 2023

Also please make sure all CI passed.

@wz337
Copy link
Contributor Author

wz337 commented Sep 12, 2023

@pytorchmergebot merge -i

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Sep 12, 2023
@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: This PR has internal changes and must be landed via Phabricator

Details for Dev Infra team Raised by workflow job

@wz337 wz337 mentioned this pull request Sep 12, 2023
Closed
@wz337
Copy link
Contributor Author

wz337 commented Sep 12, 2023

Closing and replacing it with #109096

@wz337 wz337 closed this Sep 12, 2023
pytorchmergebot pushed a commit that referenced this pull request Sep 12, 2023
@wz337 @pytorchmergebot
[DTensor] Remove compute_local_offset from _utils.py (#109096)
6dc56d3 
Separating internal changes with OSS changes. This PR contains removing the compute_local_offset from the OSS directory only.

This replaces #108965
Pull Request resolved: #109096
Approved by: https://github.com/wanchaol, https://github.com/fduwjj
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fduwjj fduwjj fduwjj approved these changes

@wanchaol wanchaol wanchaol approved these changes

@mrshenli mrshenli Awaiting requested review from mrshenli

@zhaojuanmao zhaojuanmao Awaiting requested review from zhaojuanmao

@rohan-varma rohan-varma Awaiting requested review from rohan-varma

@H-Huang H-Huang Awaiting requested review from H-Huang

@awgu awgu Awaiting requested review from awgu

@kwen2501 kwen2501 Awaiting requested review from kwen2501

@fegin fegin Awaiting requested review from fegin

@kiukchung kiukchung Awaiting requested review from kiukchung

@d4l3k d4l3k Awaiting requested review from d4l3k

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request fb-exported topic: not user facing topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@wz337 @facebook-github-bot @fduwjj @pytorchmergebot @wanchaol