Add memory overlap check to meta_copy_
#108989
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes `test_copy_many_to_one`. [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/108989
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 537ab59 with merge base 8ff0036 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
int3
added a commit
that referenced
this pull request
Sep 10, 2023
Fixes `test_copy_many_to_one`. ghstack-source-id: e7585cc9e737ff9970ff6c1dc76b62cd0dae0bb4 Pull Request resolved: #108989
48 tasks
Fixes `test_copy_many_to_one`. [ghstack-poisoned]
int3
added a commit
that referenced
this pull request
Sep 11, 2023
Fixes `test_copy_many_to_one`. ghstack-source-id: 76c0fa166dfeaff158e9815120fd7a94a70319ed Pull Request resolved: #108989
|
Test failures seem unrelated |
Fixes `test_copy_many_to_one`. [ghstack-poisoned]
int3
added a commit
that referenced
this pull request
Sep 11, 2023
Fixes `test_copy_many_to_one`. ghstack-source-id: 9f0cebaf4b09cabec91fc920a334a5ff9d2b8854 Pull Request resolved: #108989
Fixes `test_copy_many_to_one`. [ghstack-poisoned]
int3
added a commit
that referenced
this pull request
Sep 12, 2023
Fixes `test_copy_many_to_one`. ghstack-source-id: 56260b0e276ee95ec80bc4f1e2085fa95ee2de5d Pull Request resolved: #108989
Fixes `test_copy_many_to_one`. [ghstack-poisoned]
int3
added a commit
that referenced
this pull request
Sep 12, 2023
Fixes `test_copy_many_to_one`. ghstack-source-id: ef6ff8e59276a10c708bc05ffdb13ff1fc3d8395 Pull Request resolved: #108989
Fixes `test_copy_many_to_one`. [ghstack-poisoned]
int3
added a commit
that referenced
this pull request
Sep 12, 2023
Fixes `test_copy_many_to_one`. ghstack-source-id: 09eb7d17cbb88279c12bd62b34139d0af9804303 Pull Request resolved: #108989
|
@pytorchbot merge |
|
This PR needs to be approved by an authorized maintainer before merge. |
eellison
approved these changes
Sep 12, 2023
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
meta_copy_#108989Fixes
test_copy_many_to_one.