Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AOTInductor] Do not hardcode directory with .cubin files #109151

Closed
wants to merge 1 commit into from
Closed

[AOTInductor] Do not hardcode directory with .cubin files #109151

wants to merge 1 commit into from

Conversation

khabinov
Copy link
Contributor

@khabinov khabinov commented Sep 12, 2023 •
edited by pytorch-bot bot

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 12, 2023 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/109151

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (2 Unrelated Failures)

As of commit c8c5336 with merge base fa62308 (image):

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Sep 12, 2023 •
edited

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: khabinov / name: Oleg Khabinov (c8c5336)

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49081883

khabinov added a commit to khabinov/pytorch that referenced this pull request Sep 12, 2023
@khabinov @facebook-github-bot
[AOTInductor] Do not hardcode directory with .cubin files (pytorch#10…
21127e9 
…9151)

Summary: Pull Request resolved: pytorch#109151

Reviewed By: frank-wei, chenyang78

Differential Revision: D49081883
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49081883

khabinov added a commit to khabinov/pytorch that referenced this pull request Sep 12, 2023
@khabinov @facebook-github-bot
[AOTInductor] Do not hardcode directory with .cubin files (pytorch#10…
c12e480 
…9151)

Summary: Pull Request resolved: pytorch#109151

Reviewed By: frank-wei, chenyang78

Differential Revision: D49081883
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49081883

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49081883

khabinov added a commit to khabinov/pytorch that referenced this pull request Sep 13, 2023
@khabinov @facebook-github-bot
[AOTInductor] Do not hardcode directory with .cubin files (pytorch#10…
a4e3568 
…9151)

Summary: Pull Request resolved: pytorch#109151

Reviewed By: frank-wei, chenyang78

Differential Revision: D49081883
@chenyang78
Copy link
Contributor

Thanks, @khabinov! LGTM overall. You may need to sign the CLA. There are some linter issues that can be addressed by running from the OSS side (you can checkout the pull request locally)

$ lintrunner -a

Also, some CI failure seems to be legit:

https://github.com/pytorch/pytorch/actions/runs/6166139422/job/16735810926

Could you take a look? Thanks!

khabinov added a commit to khabinov/pytorch that referenced this pull request Sep 13, 2023
@khabinov @facebook-github-bot
[AOTInductor] Do not hardcode directory with .cubin files (pytorch#10…
e235cda 
…9151)

Summary: Pull Request resolved: pytorch#109151

Reviewed By: frank-wei, chenyang78

Differential Revision: D49081883
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49081883

khabinov added a commit to khabinov/pytorch that referenced this pull request Sep 13, 2023
@khabinov @facebook-github-bot
[AOTInductor] Do not hardcode directory with .cubin files (pytorch#10…
7ccabce 
…9151)

Summary: Pull Request resolved: pytorch#109151

Reviewed By: frank-wei, chenyang78

Differential Revision: D49081883
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49081883

khabinov added a commit to khabinov/pytorch that referenced this pull request Sep 13, 2023
@khabinov @facebook-github-bot
[AOTInductor] Do not hardcode directory with .cubin files (pytorch#10…
c418d44 
…9151)

Summary: Pull Request resolved: pytorch#109151

Reviewed By: frank-wei, chenyang78

Differential Revision: D49081883
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49081883

khabinov added a commit to khabinov/pytorch that referenced this pull request Sep 13, 2023
@khabinov @facebook-github-bot
[AOTInductor] Do not hardcode directory with .cubin files (pytorch#10…
3a0ac7b 
…9151)

Summary: Pull Request resolved: pytorch#109151

Reviewed By: frank-wei, chenyang78

Differential Revision: D49081883
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49081883

khabinov added a commit to khabinov/pytorch that referenced this pull request Sep 13, 2023
@khabinov @facebook-github-bot
[AOTInductor] Do not hardcode directory with .cubin files (pytorch#10…
d7442b9 
…9151)

Summary: Pull Request resolved: pytorch#109151

Reviewed By: frank-wei, chenyang78

Differential Revision: D49081883
@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: This PR has internal changes and must be landed via Phabricator

Details for Dev Infra team Raised by workflow job

khabinov added a commit to khabinov/pytorch that referenced this pull request Sep 14, 2023
@khabinov @facebook-github-bot
[AOTInductor] Do not hardcode directory with .cubin files (pytorch#10…
b8ada7e 
…9151)

Summary: Pull Request resolved: pytorch#109151

Reviewed By: frank-wei, chenyang78

Differential Revision: D49081883
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49081883

khabinov added a commit to khabinov/pytorch that referenced this pull request Sep 14, 2023
@khabinov @facebook-github-bot
[AOTInductor] Do not hardcode directory with .cubin files (pytorch#10…
9f8ebc3 
…9151)

Summary: Pull Request resolved: pytorch#109151

Reviewed By: frank-wei, chenyang78

Differential Revision: D49081883
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49081883

khabinov added a commit to khabinov/pytorch that referenced this pull request Sep 14, 2023
@khabinov @facebook-github-bot
[AOTInductor] Do not hardcode directory with .cubin files (pytorch#10…
4901cd6 
…9151)

Summary: Pull Request resolved: pytorch#109151

Reviewed By: frank-wei, chenyang78

Differential Revision: D49081883
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49081883

khabinov added a commit to khabinov/pytorch that referenced this pull request Sep 14, 2023
@khabinov @facebook-github-bot
[AOTInductor] Do not hardcode directory with .cubin files (pytorch#10…
e915bb3 
…9151)

Summary: Pull Request resolved: pytorch#109151

Reviewed By: frank-wei, chenyang78

Differential Revision: D49081883
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49081883

khabinov added a commit to khabinov/pytorch that referenced this pull request Sep 14, 2023
@khabinov @facebook-github-bot
[AOTInductor] Do not hardcode directory with .cubin files (pytorch#10…
53692fb 
…9151)

Summary: Pull Request resolved: pytorch#109151

Reviewed By: frank-wei, chenyang78

Differential Revision: D49081883
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49081883

@khabinov @facebook-github-bot
[AOTInductor] Do not hardcode directory with .cubin files (pytorch#10…
c8c5336 
…9151)

Summary: Pull Request resolved: pytorch#109151

Reviewed By: frank-wei, chenyang78

Differential Revision: D49081883
khabinov added a commit to khabinov/pytorch that referenced this pull request Sep 14, 2023
@khabinov @facebook-github-bot
[AOTInductor] Do not hardcode directory with .cubin files (pytorch#10…
727ad20 
…9151)

Summary: Pull Request resolved: pytorch#109151

Reviewed By: frank-wei, chenyang78

Differential Revision: D49081883
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49081883

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49081883

@facebook-github-bot
Copy link
Contributor

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenyang78 chenyang78 chenyang78 approved these changes

Assignees
No one assigned
Labels
ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request fb-exported Merged module: inductor topic: not user facing topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@khabinov @facebook-github-bot @chenyang78 @pytorchmergebot