[dtensor] quick fix to #109306 #109428
Closed
[dtensor] quick fix to #109306 #109428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks like the op argument schema type check is not reliable.. for things like aten.div.Tensor(Tensor, Tensor), the second argument can be a float/scalar for some reason, switch to check with the instance type directly [ghstack-poisoned]
wanchaol
requested review from
mrshenli,
zhaojuanmao,
rohan-varma,
H-Huang,
awgu,
kwen2501,
fegin,
fduwjj,
kiukchung,
d4l3k and
wz337
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/109428
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 8441b9a with merge base 393fe93 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
wanchaol
added a commit
that referenced
this pull request
Sep 16, 2023
Looks like the op argument schema type check is not reliable.. for things like aten.div.Tensor(Tensor, Tensor), the second argument can be a float/scalar for some reason, switch to check with the instance type directly ghstack-source-id: 0b4b59453bf1da6050c0771b160079a3d2247cf9 Pull Request resolved: #109428
wanchaol
added
ciflow/trunk
Looks like the op argument schema type check is not reliable.. for things like aten.div.Tensor(Tensor, Tensor), the second argument can still be a float/scalar for some reason, switch to check with the instance type directly [ghstack-poisoned]
wanchaol
added a commit
that referenced
this pull request
Sep 16, 2023
Looks like the op argument schema type check is not reliable.. for things like aten.div.Tensor(Tensor, Tensor), the second argument can be a float/scalar for some reason, switch to check with the instance type directly ghstack-source-id: 720f52a28bdf1bb3923875b6079235eafb6e7dbb Pull Request resolved: #109428
awgu
approved these changes
Sep 16, 2023
fegin
approved these changes
Sep 16, 2023
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
This was referenced Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Looks like the op argument schema type check is not reliable.. for
things like aten.div.Tensor(Tensor, Tensor), the second argument can still be
a float/scalar for some reason, switch to check with the instance type
directly