Trace calls with Python Enum values.
#109507
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix: #82135 [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/109507
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 047f60a with merge base 595af26 ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Fix: #82135 [ghstack-poisoned]
Fix: #82135 [ghstack-poisoned]
ezyang
reviewed
Sep 20, 2023
| @@ -286,7 +287,7 @@ def no_node(arg): | |||
| kwargs = {field.name: self.create_arg(getattr(a, field.name)) for field in fields(a)} | |||
| return self.create_node("call_function", a.__class__, (), kwargs) | |||
|
|
|||
| elif isinstance(a, base_types) or a is None or a is ...: | |||
| elif isinstance(a, (*base_types, enum.Enum)) or a is None or a is ...: | |||
There was a problem hiding this comment.
why not put it in base_types directly?
|
@pytorchbot merge |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
Looks fine, but what’s the purpose? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Enumvalues. #109507Fix: #82135