Add global_step parameter to SummaryWriter.add_hparams

[ringohoffman]

Fixes #37738 where all hparam metrics can only be plotted at step 0. This is basically just a resubmission of #50653.

before:

after:

@ngimel @J0Nreynolds @ezyang @albanD

[pytorch-bot]

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/109572

• 📄 Preview Python docs built from this PR
• 📄 Preview C++ docs built from this PR
• ❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 27e800b with merge base a6d34c6 ():

NEW FAILURE - The following job has failed:

• linux-focal-rocm5.6-py3.8 / test (default, 3, 3, linux.rocm.gpu) (gh)

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[ezyang]

@pytorchbot merge

[pytorchmergebot]

Merge failed

Reason: This PR needs a release notes: label
If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Details for Dev Infra team

Raised by workflow job

[ringohoffman]

@ezyang Can you add a release notes tag?

[ezyang]

@pytorchbot merge

[pytorchmergebot]

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

[pytorchmergebot]

Merge failed

Reason: 1 jobs have failed, first few of them are: trunk / linux-focal-rocm5.6-py3.8 / test (default, 3, 3, linux.rocm.gpu)

Details for Dev Infra team

Raised by workflow job

[ringohoffman]

Can the 1 failing job be retried? The failure looks unrelated.

=================================== FAILURES ===================================
____ TestCommonCUDA.test_python_ref__refs__conversions_float_cuda_complex64 ____
Traceback (most recent call last):
  File "test_ops.py", line 470, in test_python_ref
    self._ref_test_helper(lambda: TorchRefsMode(strict=True), device, dtype, op)
  File "test_ops.py", line 453, in _ref_test_helper
    self.assertTrue(ref_distance <= torch_distance, msg=msg)
  File "/opt/conda/envs/py_3.8/lib/python3.8/unittest/case.py", line 765, in assertTrue
    raise self.failureException(msg)
AssertionError: tensor(False, device='cuda:0') is not true : Reference result was farther (201.09133911132812) from the > precise computation than the torch result was (0.0)!

[ezyang]

@pytorchbot merge -f "spurious fail"

[pytorchmergebot]

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here