Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add finfo properties for float8 dtypes #109744

Closed
wants to merge 2 commits into from
Closed

Add finfo properties for float8 dtypes #109744

wants to merge 2 commits into from

Conversation

malfet
Copy link
Contributor

@malfet malfet commented Sep 20, 2023 •
edited

Stack from ghstack (oldest at bottom):

Add float8 finfo checks to test_type_info.py
Fixes #109737

@malfet malfet mentioned this pull request Sep 20, 2023
Closed
@pytorch-bot
Copy link

pytorch-bot bot commented Sep 20, 2023 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/109744

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 9f5e88e with merge base cadb566 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

malfet added a commit that referenced this pull request Sep 20, 2023
@malfet
Add finfo properties for float8 dtypes
c26c4d7 
Fixes #109737

ghstack-source-id: 193e707b9e1925a339a67a36ed17c090391b9e32
Pull Request resolved: #109744
@malfet malfet assigned albanD and unassigned albanD Sep 20, 2023
@malfet malfet requested review from albanD, drisspg and a team September 20, 2023 22:06
drisspg
drisspg reviewed Sep 20, 2023
View reviewed changes
torch/csrc/TypeInfo.cpp Outdated Show resolved Hide resolved
drisspg
drisspg approved these changes Sep 20, 2023
View reviewed changes
Copy link
Contributor

@drisspg drisspg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good though

@malfet malfet added release notes: python_frontend release notes category topic: bug fixes topic category labels Sep 20, 2023
@malfet
Copy link
Contributor Author

malfet commented Sep 20, 2023

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Sep 20, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@malfet
Copy link
Contributor Author

malfet commented Sep 21, 2023

@pytorchbot merge -f "Don't want to wait for ROCm"

@pytorchmergebot
Copy link
Collaborator

The merge job was canceled. If you believe this is a mistake, then you can re trigger it through pytorch-bot.

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@malfet malfet mentioned this pull request Sep 21, 2023
Merged
malfet added a commit that referenced this pull request Sep 21, 2023
@malfet
Add finfo properties for float8 dtypes (#109744)
385c12d 
Add float8 finfo checks to `test_type_info.py`
Fixes #109737
Pull Request resolved: #109744
Approved by: https://github.com/drisspg

(cherry picked from commit cddd0db)
@malfet malfet mentioned this pull request Sep 21, 2023
Closed
malfet added a commit that referenced this pull request Sep 21, 2023
@malfet
[Release-2.1]Add finfo properties for float8 dtypes (#109808)
539a971 
Add float8 finfo checks to `test_type_info.py`
Fixes #109737
Cherry-pick of #109744 into release/2.1 branch
Approved by: https://github.com/drisspg

(cherry picked from commit cddd0db)
pytorchmergebot pushed a commit that referenced this pull request Sep 22, 2023
@malfet @pytorchmergebot
Handle C++ exceptions raised during finfo/iinfo calls (#109743)
f092eec 
Partially fixes #109737
Pull Request resolved: #109743
Approved by: https://github.com/albanD
ghstack dependencies: #109744
@facebook-github-bot facebook-github-bot deleted the gh/malfet/47/head branch September 24, 2023 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drisspg drisspg drisspg approved these changes

@peterbell10 peterbell10 Awaiting requested review from peterbell10

@albanD albanD Awaiting requested review from albanD

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: python_frontend release notes category topic: bug fixes topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@malfet @pytorchmergebot @drisspg @albanD