Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inductor CI (by updating graph break count) #110160

Closed
wants to merge 1 commit into from

Conversation

zou3519
Copy link
Contributor

@zou3519 zou3519 commented Sep 27, 2023

Stack from ghstack (oldest at bottom):

There was a vision hash update which led to fewer graph breaks. This
seems expected to me (because the hash update included
pytorch/vision#7944 and nms is used in maskrcnn).

Test Plan:

  • wait for ci

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @Xia-Weiwen @wenzhe-nrv @jiayisunx @chenyang78 @aakhundov @kadeng

There was a vision hash update which led to fewer graph breaks. This
seems expected to me (because the hash update included
pytorch/vision#7944 and nms is used in maskrcnn).

Test Plan:
- wait for ci

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Sep 27, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/110160

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 9 Pending

As of commit 11e36ef with merge base 34ded74 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

zou3519 added a commit that referenced this pull request Sep 27, 2023
There was a vision hash update which led to fewer graph breaks. This
seems expected to me (because the hash update included
pytorch/vision#7944 and nms is used in maskrcnn).

Test Plan:
- wait for ci

ghstack-source-id: 3e43580cab52245e7d87b407508fc5751482c620
Pull Request resolved: #110160
@zou3519 zou3519 added the ciflow/trunk Trigger trunk jobs on your pull request label Sep 27, 2023
@zou3519 zou3519 requested a review from ezyang September 27, 2023 14:31
@ezyang
Copy link
Contributor

ezyang commented Sep 27, 2023

@pytorchbot merge -f "fix broken ci"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: dynamo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants