Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cuda] Replace L1 access with warp shuffles in layer_norm_grad_input_kernel #110203

Closed
wants to merge 0 commits into from

Conversation

valentinandrei
Copy link
Contributor

@valentinandrei valentinandrei commented Sep 28, 2023

Replaces accessing L1 for gamma_val, c_h and c_loss with a warp shuffles. This is guaranteed to work as the unroll factor is lower than the warp width. On average it brings speedups between 0 and 25%.

We measured using the benchmark described in #107287

Fixes #ISSUE_NUMBER

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 28, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/110203

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (6 Unrelated Failures)

As of commit 1e7947b with merge base 1e7947b (image):

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: cuda release notes category label Sep 28, 2023
@valentinandrei valentinandrei changed the title [cuda] Replace smem sync with warp shuffles in layer_norm_grad_input_kernel [cuda] Replace L1 access with warp shuffles in layer_norm_grad_input_kernel Sep 28, 2023
@guangyey guangyey temporarily deployed to pytorchbot-env October 11, 2023 06:04 — with GitHub Actions Inactive
@PaliC PaliC temporarily deployed to upload-stats October 11, 2023 06:05 — with GitHub Actions Inactive
@pytorch-bot pytorch-bot bot temporarily deployed to mergebot October 11, 2023 06:07 Inactive
@pytorch-bot pytorch-bot bot temporarily deployed to pytorchbot-env October 11, 2023 06:08 Inactive
@pytorch-bot pytorch-bot bot temporarily deployed to upload-stats October 11, 2023 06:08 Inactive
@pytorch-bot pytorch-bot bot temporarily deployed to mergebot October 11, 2023 06:10 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release notes: cuda release notes category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants