New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ROCm] conditionally enable hipsparse const descriptors for version >= 2.4.0 #110317
Conversation
…#1217) * conditionally enable hipsparse const descriptors * update hipsparse const API version condition to 2.4.0
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/110317
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit f15f5b3 with merge base 359c2a5 (): This comment was automatically generated by Dr. CI and updates every 15 minutes. |
@jeffdaily @malfet Adding |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM if CI is green
To prevent compilation errors on non-ROCm platforms.
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
…= 2.4.0 (pytorch#110317) This is in preparation for upcoming backwards-incompatible hipsparse changes. Pull Request resolved: pytorch#110317 Approved by: https://github.com/malfet
This is in preparation for upcoming backwards-incompatible hipsparse changes.
cc @sunway513 @jithunnair-amd @pruthvistony @ROCmSupport @dllehr-amd @jataylo @hongxiayang