Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pin_memory support for NT #110404

Closed
wants to merge 6 commits into from
Closed

pin_memory support for NT #110404

wants to merge 6 commits into from

Conversation

jbschlosser
Copy link
Contributor

@jbschlosser jbschlosser commented Oct 2, 2023 •
edited

@jbschlosser
pin_memory support for NT
f037dca 
[ghstack-poisoned]
@jbschlosser jbschlosser mentioned this pull request Oct 2, 2023
Closed
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 2, 2023 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/110404

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (2 Unrelated Failures)

As of commit 91ee32c with merge base 46a5558 (image):

UNSTABLE - The following jobs failed but were likely due to flakiness present on trunk and has been marked as unstable:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

jbschlosser added a commit that referenced this pull request Oct 2, 2023
@jbschlosser
pin_memory support for NT
8af4ee3 
ghstack-source-id: 02f149130fb37d360be9435d9135921343a33b29
Pull Request resolved: #110404
jbschlosser added a commit that referenced this pull request Oct 2, 2023
@jbschlosser
pin_memory support for NT
061d160 
ghstack-source-id: cb9b19e9a4a6c471eec65f43b373e4d0381c48dc
Pull Request resolved: #110404
@pytorch-bot pytorch-bot bot added the release notes: dataloader release notes category label Oct 4, 2023
jbschlosser added a commit that referenced this pull request Oct 4, 2023
@jbschlosser
pin_memory support for NT
76c9625 
ghstack-source-id: 1700b821857977483e69f23867e204d1ff765a27
Pull Request resolved: #110404
albanD
albanD approved these changes Oct 4, 2023
View reviewed changes
Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okok

@jbschlosser jbschlosser added topic: improvements topic category release notes: nested tensor Changes that have a direct impact on nested tensors and removed release notes: dataloader release notes category labels Oct 4, 2023
@jbschlosser
Copy link
Contributor Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 4, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@albanD
Copy link
Collaborator

albanD commented Oct 4, 2023 •
edited

Don't forget the constexpr change ;) (can be a follow up if this already landed)

@jbschlosser
Copy link
Contributor Author

Don't forget the constexpr change ;)

crap I made it locally and didn't push yet :p

jbschlosser added a commit that referenced this pull request Oct 4, 2023
@jbschlosser
pin_memory support for NT
cfef49b 
ghstack-source-id: 185f7b7e6c0e1c09cbe50b762a270a3386d6b430
Pull Request resolved: #110404
@jbschlosser
Copy link
Contributor Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

The merge job was canceled. If you believe this is a mistake, then you can re trigger it through pytorch-bot.

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

jbschlosser added a commit that referenced this pull request Oct 4, 2023
@jbschlosser
pin_memory support for NT
909b7a0 
ghstack-source-id: fcc16e3726ee7b8cd95e5d5780662dd005b4ff48
Pull Request resolved: #110404
@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: New commits were pushed while merging. Please rerun the merge command.

Details for Dev Infra team Raised by workflow job

@jbschlosser
Copy link
Contributor Author

@pytorchbot merge -f "ignore spurious failures"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

This was referenced Oct 5, 2023
Closed
Closed
@kit1980
Copy link
Member

kit1980 commented Oct 5, 2023

@albanD @jbschlosser Looks like this PR or the previous one in the stack broke slow tests: https://github.com/pytorch/pytorch/actions/runs/6424291531/job/17445721752

RuntimeError: CUDA driver API confirmed a leak in main.TestDataLoaderDeviceTypeCUDA.test_nested_tensor_multiprocessing_context_forkserver_cuda! Caching allocator allocated memory was 5120 and is now reported as 10240 on device 0. CUDA driver allocated memory was 340459520 and is now 342556672.

I'm verifying which PR exactly, but likely we'll need to revert this.

@kit1980
Copy link
Member

kit1980 commented Oct 6, 2023

@pytorchbot revert -m "Previous PR in the stack caused CUDA memory leaks" -c nosignal

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

@pytorchmergebot
Copy link
Collaborator

@jbschlosser your PR has been successfully reverted.

pytorchmergebot added a commit that referenced this pull request Oct 6, 2023
@pytorchmergebot
Revert "pin_memory support for NT (#110404)"
81ce5d5 
This reverts commit 3597325.

Reverted #110404 on behalf of https://github.com/kit1980 due to Previous PR in the stack caused CUDA memory leaks ([comment](#110404 (comment)))
@jbschlosser jbschlosser reopened this Oct 6, 2023
jbschlosser added a commit that referenced this pull request Oct 10, 2023
@jbschlosser
pin_memory support for NT
3eba196 
ghstack-source-id: 83880e73ae207255bb2d8a0e5372a82b31a01fd0
Pull Request resolved: #110404
@jbschlosser
Copy link
Contributor Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@facebook-github-bot facebook-github-bot deleted the gh/jbschlosser/92/head branch October 14, 2023 14:24
@jbschlosser jbschlosser mentioned this pull request Jan 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soulitzer soulitzer soulitzer left review comments

@cpuhrsch cpuhrsch cpuhrsch approved these changes

@albanD albanD albanD approved these changes

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: nested tensor Changes that have a direct impact on nested tensors Reverted topic: improvements topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@jbschlosser @pytorchmergebot @albanD @kit1980 @cpuhrsch @soulitzer