Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate MacOs wheel binary builds to ephemeral M1 runners #110432

Closed

Conversation

malfet
Copy link
Contributor

@malfet malfet commented Oct 3, 2023

Surprisingly there are no speed difference between running the cross-compilation on macos12-xl (x86_64 12 core machine) and macos-13-xlarge (m1 6 core machine)

Most of the changes are on the https://github.com/pytorch/builder side:

@malfet malfet requested a review from a team as a code owner October 3, 2023 02:37
@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Oct 3, 2023
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 3, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/110432

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 51858d9 with merge base 428cbd7 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@malfet malfet added the ciflow/binaries_wheel Trigger binary build and upload jobs for wheel on the PR label Oct 3, 2023
@malfet malfet changed the title Move binary builds to GitHub M1 runners Migrate MacOs wheel binary builds to ephemeral M1 runners Oct 3, 2023
@malfet malfet force-pushed the malfet/move-apple-silicone-binary-builds-to-native branch from ac83d4f to 51858d9 Compare October 3, 2023 14:09
@malfet
Copy link
Contributor Author

malfet commented Oct 3, 2023

@pytorchbot merge -f "wheel builds are green"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@malfet malfet deleted the malfet/move-apple-silicone-binary-builds-to-native branch December 18, 2023 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/binaries_wheel Trigger binary build and upload jobs for wheel on the PR Merged topic: not user facing topic category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants