[dtensor] support aten.where and enable implicit scalar promotion #110584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds support for aten.where and support implicit scalar promotion, basically when we meet scalar tensors in dispatching logic, we implicitly convert it those to replicated dtensor The latter also enables bunch of ops in op db to pass [ghstack-poisoned]
wanchaol
requested review from
mrshenli,
zhaojuanmao,
rohan-varma,
H-Huang,
awgu,
kwen2501,
fegin,
fduwjj,
wz337 and
kiukchung
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/110584
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit c51d8c6 with merge base 7f0a659 ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
fduwjj
reviewed
Oct 5, 2023
…omotion" This PR adds support for aten.where and support implicit scalar promotion, basically when we meet scalar tensors in dispatching logic, we implicitly convert it those to replicated dtensor The latter also enables bunch of ops in op db to pass [ghstack-poisoned]
|
@fduwjj could you stamp the PR if there's no other comments :) |
pytorchmergebot
pushed a commit
that referenced
this pull request
Oct 7, 2023
This PR enables lt/gt aten op Pull Request resolved: #110585 Approved by: https://github.com/fduwjj ghstack dependencies: #110584
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This PR adds support for aten.where and support implicit scalar
promotion, basically when we meet scalar tensors in dispatching logic,
we implicitly convert it those to replicated dtensor
The latter also enables bunch of ops in op db to pass