different bounds for same Dim name #110638
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Differential Revision: [D49965944](https://our.internmc.facebook.com/intern/diff/D49965944/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/110638
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (2 Unrelated Failures)As of commit d511172 with merge base 11b3210 ( UNSTABLE - The following jobs failed but were likely due to flakiness present on trunk and has been marked as unstable:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
avikchaudhuri
added a commit
that referenced
this pull request
Oct 5, 2023
Differential Revision: [D49965944](https://our.internmc.facebook.com/intern/diff/D49965944/) ghstack-source-id: 203066884 Pull Request resolved: #110638
Previously,`Dim` definitions that shared the same name but had different ranges were allowed to appear in the `dynamic_shapes` argument of an `export` call. They would correspond to the *same* dynamic dimension (identified by the shared name) with an effective range would be the *intersection* of the different ranges. However this behavior can be confusing, because having different definitions with the same name is more likely than not unintentional. Therefore, this PR makes it a user error. We still allow different definitions with the same name to exist at the same time (no global uniqueness) as long as they are not confused in the same `export` call. Redefinitions with the same bounds are also allowed, in case they are accidentally created by executing the same code multiple times. Differential Revision: [D49965944](https://our.internmc.facebook.com/intern/diff/D49965944/) cc gmagogsfm [ghstack-poisoned]
avikchaudhuri
added a commit
that referenced
this pull request
Oct 5, 2023
Pull Request resolved: #110638 ghstack-source-id: 203103684 @exported-using-ghexport Differential Revision: [D49965944](https://our.internmc.facebook.com/intern/diff/D49965944/)
Previously,`Dim` definitions that shared the same name but had different ranges were allowed to appear in the `dynamic_shapes` argument of an `export` call. They would correspond to the *same* dynamic dimension (identified by the shared name) with an effective range would be the *intersection* of the different ranges. However this behavior can be confusing, because having different definitions with the same name is more likely than not unintentional. Therefore, this PR makes it a user error. We still allow different definitions with the same name to exist at the same time (no global uniqueness) as long as they are not confused in the same `export` call. Redefinitions with the same bounds are also allowed, in case they are accidentally created by executing the same code multiple times. Differential Revision: [D49965944](https://our.internmc.facebook.com/intern/diff/D49965944/) cc gmagogsfm [ghstack-poisoned]
avikchaudhuri
added a commit
that referenced
this pull request
Oct 6, 2023
Pull Request resolved: #110638 ghstack-source-id: 203117236 @exported-using-ghexport Differential Revision: [D49965944](https://our.internmc.facebook.com/intern/diff/D49965944/)
Previously,`Dim` definitions that shared the same name but had different ranges were allowed to appear in the `dynamic_shapes` argument of an `export` call. They would correspond to the *same* dynamic dimension (identified by the shared name) with an effective range would be the *intersection* of the different ranges. However this behavior can be confusing, because having different definitions with the same name is more likely than not unintentional. Therefore, this PR makes it a user error. We still allow different definitions with the same name to exist at the same time (no global uniqueness) as long as they are not confused in the same `export` call. Redefinitions with the same bounds are also allowed, in case they are accidentally created by executing the same code multiple times. Differential Revision: [D49965944](https://our.internmc.facebook.com/intern/diff/D49965944/) cc gmagogsfm [ghstack-poisoned]
avikchaudhuri
added a commit
that referenced
this pull request
Oct 6, 2023
Pull Request resolved: #110638 ghstack-source-id: 203199273 @exported-using-ghexport Differential Revision: [D49965944](https://our.internmc.facebook.com/intern/diff/D49965944/)
avikchaudhuri
requested review from
zhxchen17,
tugsbayasgalan,
gmagogsfm and
ydwu4
zhxchen17
approved these changes
Oct 6, 2023
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Previously,
Dimdefinitions that shared the same name but had different ranges were allowed to appear in thedynamic_shapesargument of anexportcall. They would correspond to the same dynamic dimension (identified by the shared name) with an effective range would be the intersection of the different ranges.However this behavior can be confusing, because having different definitions with the same name is more likely than not unintentional. Therefore, this PR makes it a user error.
We still allow different definitions with the same name to exist at the same time (no global uniqueness) as long as they are not confused in the same
exportcall. Redefinitions with the same bounds are also allowed, in case they are accidentally created by executing the same code multiple times.Differential Revision: D49965944
cc @gmagogsfm @zhxchen17 @tugsbayasgalan