Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(optim/dynamo): shortcut is_sparse iteration in SGD multi_tensor #110648

Conversation

jon-chuang
Copy link
Collaborator

@jon-chuang jon-chuang commented Oct 5, 2023

Originated: #110353 (comment)

Speeds up significantly in non-sparse path (majority use-case).

Benchmarks: #110506 (comment)

CC: @janeyx99

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 5, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/110648

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (2 Unrelated Failures)

As of commit b6a1ca4 with merge base 9e72c9c (image):

UNSTABLE - The following jobs failed but were likely due to flakiness present on trunk and has been marked as unstable:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@jon-chuang jon-chuang changed the title feat(optim): shortcut is_sparse iteration feat(optim): shortcut is_sparse iteration in SGD multi_tensor Oct 5, 2023
@jon-chuang jon-chuang changed the title feat(optim): shortcut is_sparse iteration in SGD multi_tensor perf(optim/dynamo): shortcut is_sparse iteration in SGD multi_tensor Oct 5, 2023
@soulitzer soulitzer added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Oct 5, 2023
@janeyx99
Copy link
Contributor

janeyx99 commented Oct 6, 2023

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 6, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged open source release notes: optim triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants