New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FSDP][optim_state_dict] Move local optimizer state to FSDP compute_device #110929
Conversation
…evice This will ensure all the tensors are on FSDP compute_device. Differential Revision: [D50059492](https://our.internmc.facebook.com/intern/diff/D50059492/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/110929
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (2 Unrelated Failures)As of commit b70d171 with merge base f952551 (): FLAKY - The following job failed but was likely due to flakiness present on trunk:
UNSTABLE - The following job failed but was likely due to flakiness present on trunk and has been marked as unstable:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
…evice This will ensure all the tensors are on FSDP compute_device. Differential Revision: [D50059492](https://our.internmc.facebook.com/intern/diff/D50059492/) ghstack-source-id: 203487018 Pull Request resolved: #110929
…P compute_device" This will ensure all the tensors are on FSDP compute_device. Differential Revision: [D50059492](https://our.internmc.facebook.com/intern/diff/D50059492/) [ghstack-poisoned]
…evice Pull Request resolved: #110929 This will ensure all the tensors are on FSDP compute_device. ghstack-source-id: 203487507 @exported-using-ghexport Differential Revision: [D50059492](https://our.internmc.facebook.com/intern/diff/D50059492/)
…P compute_device" This will ensure all the tensors are on FSDP compute_device. Differential Revision: [D50059492](https://our.internmc.facebook.com/intern/diff/D50059492/) [ghstack-poisoned]
…evice Pull Request resolved: #110929 This will ensure all the tensors are on FSDP compute_device. ghstack-source-id: 203487574 @exported-using-ghexport Differential Revision: [D50059492](https://our.internmc.facebook.com/intern/diff/D50059492/)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
…P compute_device" This will ensure all the tensors are on FSDP compute_device. Differential Revision: [D50059492](https://our.internmc.facebook.com/intern/diff/D50059492/) [ghstack-poisoned]
…evice Pull Request resolved: #110929 This will ensure all the tensors are on FSDP compute_device. ghstack-source-id: 203487927 @exported-using-ghexport Differential Revision: [D50059492](https://our.internmc.facebook.com/intern/diff/D50059492/)
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Stack from ghstack (oldest at bottom):
This will ensure all the tensors are on FSDP compute_device.
Differential Revision: D50059492