Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ScalarTensor or 0dim overload for _foreach_add #111079

Closed
wants to merge 5 commits into from
Closed

Add ScalarTensor or 0dim overload for _foreach_add #111079

wants to merge 5 commits into from

Commits on Oct 11, 2023

  1. Add ScalarTensor or 0dim overload for _foreach_add 

    [ghstack-poisoned]
    @janeyx99
    janeyx99 committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    2560ccd View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2023

  1. Update on "Add ScalarTensor or 0dim overload for _foreach_add" 

    Adding a Tensor overload will allow us to:
- optimize in more cases than before
- increase coverage for scalarTensor instead of just scalars in our foreach APIs

The main complication in this PR was that add.Tensor has a scalar overload, so I've now built out support for that.

cc crcrpar 




[ghstack-poisoned]
    @janeyx99
    janeyx99 committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    32f68ba View commit details
    Browse the repository at this point in the history

  2. Update on "Add ScalarTensor or 0dim overload for _foreach_add" 

    Adding a Tensor overload will allow us to:
- optimize in more cases than before
- increase coverage for scalarTensor instead of just scalars in our foreach APIs

The main complication in this PR was that add.Tensor has a scalar overload, so I've now built out support for that.

cc crcrpar 




[ghstack-poisoned]
    @janeyx99
    janeyx99 committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    792ff30 View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2023

  1. Update on "Add ScalarTensor or 0dim overload for _foreach_add" 

    Adding a Tensor overload will allow us to:
- optimize in more cases than before
- increase coverage for scalarTensor instead of just scalars in our foreach APIs

The main complication in this PR was that add.Tensor has a scalar overload, so I've now built out support for that.

cc crcrpar 




[ghstack-poisoned]
    @janeyx99
    janeyx99 committed Oct 14, 2023
    Configuration menu
    Copy the full SHA
    9b19da0 View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2023

  1. Update on "Add ScalarTensor or 0dim overload for _foreach_add" 

    Adding a Tensor overload will allow us to:
- optimize in more cases than before
- increase coverage for scalarTensor instead of just scalars in our foreach APIs

The main complication in this PR was that add.Tensor has a scalar overload, so I've now built out support for that.

cc crcrpar 




[ghstack-poisoned]
    @janeyx99
    janeyx99 committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    cd75529 View commit details
    Browse the repository at this point in the history