Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Fix typo in cpp/installing when wheel is used #111143

Closed
wants to merge 1 commit into from
Closed

Conversation

malfet
Copy link
Contributor

@malfet malfet commented Oct 12, 2023

🤖 Generated by Copilot at 34a15a6

Updated the cmake command in docs/cpp/source/installing.rst to use python3 and fix a documentation error.

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 12, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/111143

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 34a15a6 with merge base dede1e9 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@malfet malfet requested a review from a team October 12, 2023 17:47
@malfet malfet added release notes: cpp release notes category topic: docs topic category labels Oct 12, 2023
Copy link
Contributor

@rajveer43 rajveer43 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@rajveer43
Copy link
Contributor

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 13, 2023
@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 mandatory check(s) are pending/not yet run. The first few are:

  • EasyCLA

Dig deeper by viewing the pending checks on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@malfet
Copy link
Contributor Author

malfet commented Oct 13, 2023

/easycla

@malfet
Copy link
Contributor Author

malfet commented Oct 13, 2023

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@malfet malfet deleted the malfet-patch-29 branch October 18, 2023 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: cpp release notes category topic: docs topic category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants