Freeze fuse two mms #111232
Closed
Freeze fuse two mms #111232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/111232
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (3 Unrelated Failures)As of commit 0d8a9d4 with merge base 543a763 ( FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
UNSTABLE - The following job failed but was likely due to flakiness present on trunk and has been marked as unstable:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Improves llama_v2 perf locally from 1.48x -> 1.55x. A good future rewrite would be to unify the freezing batching with the other batching rules that yanboliang & co were working on. I want to wait for the forthcoming pre-dispatch changes to settle down first. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 aakhundov ColinPeppler [ghstack-poisoned]
Improves llama_v2 perf locally from 1.48x -> 1.55x. A good future rewrite would be to unify the freezing batching with the other batching rules that yanboliang & co were working on. I want to wait for the forthcoming pre-dispatch changes to settle down first. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 aakhundov ColinPeppler [ghstack-poisoned]
|
batching rules you say?? |
|
To be more clear, this batches horizontal mms that share a single input where the other inputs are parameters, and constant folds the concat of the params in freezing. |
jansel
requested changes
Oct 13, 2023
Comment on lines
+181
to
+182
| self.t1 = torch.nn.Parameter(torch.rand(10, 10)) | ||
| self.t2 = torch.nn.Parameter(torch.rand(10, 10)) |
There was a problem hiding this comment.
Can you add a test where the sizes of t1/t2 aren't the same?
Improves llama_v2 perf locally from 1.48x -> 1.55x. A good future rewrite would be to unify the freezing batching with the other batching rules that yanboliang & co were working on. I want to wait for the forthcoming pre-dispatch changes to settle down first. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 aakhundov ColinPeppler [ghstack-poisoned]
Chillee
approved these changes
Oct 19, 2023
eellison
added
ciflow/trunk
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
DacinTitus
pushed a commit
to DacinTitus/PyTorch
that referenced
this pull request
Nov 4, 2023
ghstack-source-id: e2f6c418861608b399ca08733dec4e1c38e79ba1 Pull Request resolved: pytorch/pytorch#111232
xuhancn
pushed a commit
to xuhancn/pytorch
that referenced
this pull request
Nov 7, 2023
Improves llama_v2 perf locally from 1.48x -> 1.55x. A good future rewrite would be to unify the freezing batching with the other batching rules that @yanboliang & co were working on. I want to wait for the forthcoming pre-dispatch changes to settle down first. Pull Request resolved: pytorch#111232 Approved by: https://github.com/Chillee
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Improves llama_v2 perf locally from 1.48x -> 1.55x.
A good future rewrite would be to unify the freezing batching with the other batching rules that @yanboliang & co were working on. I want to wait for the forthcoming pre-dispatch changes to settle down first.
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @Xia-Weiwen @wenzhe-nrv @jiayisunx @peterbell10 @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @aakhundov @ColinPeppler