Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BE] Compile FBGEMM with ASAN #111266

Closed
wants to merge 6 commits into from
Closed

[BE] Compile FBGEMM with ASAN #111266

wants to merge 6 commits into from

Conversation

malfet
Copy link
Contributor

@malfet malfet commented Oct 14, 2023

If USE_ASAN is set, compile FBGEMM with ASAN as well, by setting USE_SANITIZER to address,undefined

This fixes regression in sanitizer coverage introduced by #93147 that change effects of sanitizer from the entire project to just torch libraries, and finally allows one to reliably catch regression reported in #111189

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 14, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/111266

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 650768d with merge base 48e4d18 (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@malfet malfet added release notes: build release notes category topic: bug fixes topic category labels Oct 14, 2023
@malfet malfet requested a review from a team October 14, 2023 00:39
@malfet
Copy link
Contributor Author

malfet commented Oct 14, 2023

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

If `USE_ASAN` is set, compile FBGEMM with ASAN as well, by setting `USE_SANITIZER` to `address,undefined`

This fixes regression in sanitizer coverage introduced by #93147  that change effects of sanitizer from the entire project to just torch libraries
@pytorchmergebot
Copy link
Collaborator

Successfully rebased malfet-patch-31 onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout malfet-patch-31 && git pull --rebase)

@malfet
Copy link
Contributor Author

malfet commented Oct 14, 2023

@pytorchbot merge -f "ASAN tests are green"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@cyyever
Copy link
Collaborator

cyyever commented Oct 15, 2023

What I missed, thank you!

yeounoh pushed a commit to yeounoh/pytorch that referenced this pull request Oct 16, 2023
If `USE_ASAN` is set, compile FBGEMM with ASAN as well, by setting `USE_SANITIZER` to `address,undefined`

This fixes regression in sanitizer coverage introduced by pytorch#93147  that change effects of sanitizer from the entire project to just torch libraries, and finally allows one to reliably catch regression reported in pytorch#111189

Pull Request resolved: pytorch#111266
Approved by: https://github.com/huydhn
yeounoh pushed a commit to yeounoh/pytorch that referenced this pull request Oct 16, 2023
If `USE_ASAN` is set, compile FBGEMM with ASAN as well, by setting `USE_SANITIZER` to `address,undefined`

This fixes regression in sanitizer coverage introduced by pytorch#93147  that change effects of sanitizer from the entire project to just torch libraries, and finally allows one to reliably catch regression reported in pytorch#111189

Pull Request resolved: pytorch#111266
Approved by: https://github.com/huydhn
@malfet malfet deleted the malfet-patch-31 branch October 18, 2023 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants