Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix dict size change during iteration #111267

Closed
wants to merge 1 commit into from
Closed

fix dict size change during iteration #111267

wants to merge 1 commit into from

Conversation

cxxxs
Copy link
Contributor

@cxxxs cxxxs commented Oct 14, 2023 •
edited

Summary:
_wrapped_fns_to_patch points to f_globals which might change during iteration due to factors like lazy imports. This diff fixes potential runtime errors like:

RuntimeError: dictionary changed size during iteration

Test Plan: CI

Reviewed By: Kronuz

Differential Revision: D50283983

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 14, 2023 •
edited

CLA Signed

The committers listed above are authorized under a signed CLA.

@pytorch-bot pytorch-bot bot added the release notes: fx release notes category label Oct 14, 2023
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 14, 2023 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/111267

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit ff7cdaa with merge base a063238 (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50283983

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50283983

cxxxs added a commit to cxxxs/pytorch that referenced this pull request Oct 16, 2023
@cxxxs @facebook-github-bot
fix dict size change during iteration (pytorch#111267)
ac294bf 
Summary:

_wrapped_fns_to_patch points to f_globals which might change during iteration. This diff fixes potential runtime errors like:

```
RuntimeError: dictionary changed size during iteration
```

Test Plan: CI

Reviewed By: Kronuz

Differential Revision: D50283983
@cxxxs
Copy link
Contributor Author

cxxxs commented Oct 16, 2023

/easycla

1 similar comment
@cxxxs
Copy link
Contributor Author

cxxxs commented Oct 16, 2023

/easycla

@yanboliang yanboliang added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 16, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50283983

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50283983

cxxxs added a commit to cxxxs/pytorch that referenced this pull request Oct 17, 2023
@cxxxs @facebook-github-bot
fix dict size change during iteration (pytorch#111267)
d9bff02 
Summary:

_wrapped_fns_to_patch points to f_globals which might change during iteration. This diff fixes potential runtime errors like:

```
RuntimeError: dictionary changed size during iteration
```

Test Plan: CI

Reviewed By: Kronuz

Differential Revision: D50283983
@cxxxs @facebook-github-bot
fix dict size change during iteration (pytorch#111267)
ff7cdaa 
Summary:

_wrapped_fns_to_patch points to f_globals which might change during iteration. This diff fixes potential runtime errors like:

```
RuntimeError: dictionary changed size during iteration
```

Test Plan: CI

Reviewed By: Kronuz

Differential Revision: D50283983
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50283983

@facebook-github-bot
Copy link
Contributor

@pytorchbot merge -f 'Landed internally'

(Initiating merge automatically since Phabricator Diff has merged, using force because this PR might not pass merge_rules.json but landed internally)

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yanboliang yanboliang yanboliang approved these changes

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request fb-exported Merged release notes: fx release notes category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cxxxs @facebook-github-bot @pytorchmergebot @yanboliang