[AOTInductor] ProxyExecutor skips serializing missing args with default value #111425
Conversation
SherlockNoMad
requested review from
avikchaudhuri,
gmagogsfm,
tugsbayasgalan and
zhxchen17
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/111425
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (5 Unrelated Failures)As of commit b30c809 with merge base 2dc1726 ( FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
This pull request was exported from Phabricator. Differential Revision: D50345729 |
github-actions
bot
added
module: inductor
ciflow/inductor
module: export
and removed
fb-exported
labels
Not sure what's ABI mode, want to learn about that if you have time to chat. |
…lt value (pytorch#111425) Summary: In ABI-mode, we don't serialize missing args with default value. Test Plan: buck2 run mode/dev-nosan deeplearning/aot_inductor/test:test_custom_ops Differential Revision: D50345729
SherlockNoMad
force-pushed
the
export-D50345729
branch
from
1560cdf
to
67e7974
Compare
…lt value (pytorch#111425) Summary: In ABI-mode, we don't serialize missing args with default value. Test Plan: buck2 run mode/dev-nosan deeplearning/aot_inductor/test:test_custom_ops Differential Revision: D50345729
|
This pull request was exported from Phabricator. Differential Revision: D50345729 |
|
This pull request was exported from Phabricator. Differential Revision: D50345729 |
SherlockNoMad
force-pushed
the
export-D50345729
branch
from
67e7974
to
b30c809
Compare
|
@pytorchbot merge -f 'Landed internally' (Initiating merge automatically since Phabricator Diff has merged, using force because this PR might not pass merge_rules.json but landed internally) |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
| if ( | ||
| V.graph.cpp_wrapper | ||
| and hasattr(self, "args_default_value") | ||
| and not config.is_fbcode() |
There was a problem hiding this comment.
would it make more sense to check for abi_compatible directly?
Summary: In AOTInductor ABI Compatible-mode, we don't serialize missing args with default value.
Test Plan: buck2 run mode/dev-nosan deeplearning/aot_inductor/test:test_custom_ops
Differential Revision: D50345729
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @peterbell10 @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @aakhundov @ColinPeppler @avikchaudhuri @gmagogsfm @zhxchen17 @tugsbayasgalan