Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[documentation] adding desc for adaptive_autorange #111612

Closed
wants to merge 1 commit into from
Closed

[documentation] adding desc for adaptive_autorange #111612

wants to merge 1 commit into from

Conversation

HDCharles
Copy link
Contributor

@HDCharles HDCharles commented Oct 19, 2023 •
edited

Stack from ghstack (oldest at bottom):

Summary: This prevented it from showing up in docs

Test Plan: no functional changes

Reviewers:

Subscribers:

Tasks:

Tags:

@HDCharles
[documentation] adding desc for adaptive_autorange
49efdb5 
Summary: This prevented it from showing up in docs

Test Plan: no functional changes

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 19, 2023 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/111612

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 49efdb5 with merge base 102fbd4 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

HDCharles added a commit that referenced this pull request Oct 19, 2023
@HDCharles
[documentation] adding desc for adaptive_autorange
bb47f27 
Summary: This prevented it from showing up in docs

Test Plan: no functional changes

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: b168d90289f3b32ea2fd34a77f7fabec2c15fecd
Pull Request resolved: #111612
@cpuhrsch
Copy link
Contributor

cc @robieta who originally added this functionality.

cpuhrsch
cpuhrsch approved these changes Oct 20, 2023
View reviewed changes
Copy link
Contributor

@cpuhrsch cpuhrsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@HDCharles
Copy link
Contributor Author

@pytorchmergebot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 20, 2023
@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: This PR needs a release notes: label
If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Details for Dev Infra team Raised by workflow job

@HDCharles HDCharles added release notes: benchmark release notes category topic: docs topic category labels Oct 20, 2023
@HDCharles
Copy link
Contributor Author

@pytorchmergebot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@facebook-github-bot facebook-github-bot deleted the gh/HDCharles/171/head branch October 24, 2023 14:23
andreigh pushed a commit to andreigh/pytorch that referenced this pull request Oct 26, 2023
@HDCharles @andreigh
[documentation] adding desc for adaptive_autorange (pytorch#111612)
f6263ff 
Summary: This prevented it from showing up in docs

Test Plan: no functional changes

Reviewers:

Subscribers:

Tasks:

Tags:
Pull Request resolved: pytorch#111612
Approved by: https://github.com/cpuhrsch
xuhancn pushed a commit to xuhancn/pytorch that referenced this pull request Nov 7, 2023
@HDCharles @xuhancn
[documentation] adding desc for adaptive_autorange (pytorch#111612)
73868b7 
Summary: This prevented it from showing up in docs

Test Plan: no functional changes

Reviewers:

Subscribers:

Tasks:

Tags:
Pull Request resolved: pytorch#111612
Approved by: https://github.com/cpuhrsch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpuhrsch cpuhrsch cpuhrsch approved these changes

@albanD albanD Awaiting requested review from albanD

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: benchmark release notes category topic: docs topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@HDCharles @cpuhrsch @pytorchmergebot