SGR/Assistant: making sure linker drops unnecessary dependencies #112871
Conversation
Summary: Assistant/SGR is linked in a way that links to all not-reference libraries are dropped: https://www.internalfb.com/code/fbsource/[c74911ac21d6b90d1fbca8f2de08d6269f44e1fc]/xplat/toolchains/android/ndk/ndk_toolchains.bzl?lines=931 However, `caffe2` overrides this setting https://www.internalfb.com/code/fbsource/[2536ee6849b08da1adcd5b9da0e455a4af3a06d1][blame]/xplat/caffe2/c2_defs.bzl?lines=496. That results in the build breaks like discussed here: https://fb.workplace.com/groups/llvm.gcc/permalink/25390586597229949/ : Assistant doesn't use libforce_dlopen but it sill requires it, and that library exist on device. As we statically link all operators, the `caffe2` override doesn't seem to be necessary. This diff adds a build parameter affecting `caffe2` linker options. Test Plan: Built supernova experimental build, made sure Assistant starts without operator issues. Tried tts, ocr and asr command in SGR, made sure they work. Verified that hypernova build doesn't required libforce_dlopen when D50695343 is applied. Reviewed By: veselinp Differential Revision: D50870489
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/112871
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (3 Unrelated Failures)As of commit bdfe13e with merge base 44a28a5 ( FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
UNSTABLE - The following job failed but was likely due to flakiness present on trunk and has been marked as unstable:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
|
|
This pull request was exported from Phabricator. Differential Revision: D50870489 |
ZainRizvi
added
ciflow/trunk
|
@pytorchbot label "topic: not user facing |
|
❌ 🤖 pytorchbot command failed: |
|
@pytorchbot label "topic: not user facing" |
|
@pytorchbot merge |
Merge failedReason: Approval needed from one of the following: |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
Reopen this to merge the change as this is not yet merged |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Summary:
Assistant/SGR is linked in a way that links to all not-reference libraries are dropped: https://www.internalfb.com/code/fbsource/[c74911ac21d6b90d1fbca8f2de08d6269f44e1fc]/xplat/toolchains/android/ndk/ndk_toolchains.bzl?lines=931
However,
caffe2overrides this setting https://www.internalfb.com/code/fbsource/[2536ee6849b08da1adcd5b9da0e455a4af3a06d1][blame]/xplat/caffe2/c2_defs.bzl?lines=496. That results in the build breaks like discussed here: https://fb.workplace.com/groups/llvm.gcc/permalink/25390586597229949/ : Assistant doesn't use libforce_dlopen but it sill requires it, and that library exist on device.As we statically link all operators, the
caffe2override doesn't seem to be necessary.This diff adds a build parameter affecting
caffe2linker options.Test Plan:
Built supernova experimental build, made sure Assistant starts without operator issues.
Tried tts, ocr and asr command in SGR, made sure they work.
Verified that hypernova build doesn't required libforce_dlopen when D50695343 is applied.
Reviewed By: veselinp
Differential Revision: D50870489