Add all 3.12 binary build for wheel. Let's see how it goes. V2 #112882

albanD · 2023-11-03T17:59:23Z

Fixes #ISSUE_NUMBER

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @aakhundov @kadeng

pytorch-bot · 2023-11-03T17:59:27Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/112882

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 37f5ae4 with merge base f9bf104 ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

albanD · 2023-11-15T21:37:12Z

@pytorchbot merge

It's all green!

pytorchmergebot · 2023-11-15T21:40:41Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2023-11-16T00:00:00Z

Merge failed

Reason: Command git -C /home/runner/work/pytorch/pytorch fetch origin returned non-zero exit code 1

From https://github.com/pytorch/pytorch
   dd28006d8d9..1e260c851b9  main                    -> origin/main
   dbf98c1f602..f4512eaae57  csl/add_gitignore       -> origin/csl/add_gitignore
 * [new branch]              csl/coverage            -> origin/csl/coverage
 + fe705c0d795...a81999adc7c csl/test3               -> origin/csl/test3  (forced update)
 * [new branch]              dcp_stateful            -> origin/dcp_stateful
   44ba4e09e82..a09b32b5468  gh/BowenBao/316/base    -> origin/gh/BowenBao/316/base
   6ae6bbbb577..c5f74dd8a83  gh/BowenBao/316/head    -> origin/gh/BowenBao/316/head
 + ca9339d5710...1cde29c9c47 gh/BowenBao/316/orig    -> origin/gh/BowenBao/316/orig  (forced update)
   03a50c87cb7..17f90c18391  gh/BowenBao/317/base    -> origin/gh/BowenBao/317/base
   efc12322824..5ef6e72751d  gh/BowenBao/317/head    -> origin/gh/BowenBao/317/head
 + dc7e6447956...8dfc996f0f5 gh/BowenBao/317/orig    -> origin/gh/BowenBao/317/orig  (forced update)
   efc12322824..1cbce8845f8  gh/BowenBao/318/base    -> origin/gh/BowenBao/318/base
   72ce3e35bfa..33a679b6d55  gh/BowenBao/318/head    -> origin/gh/BowenBao/318/head
 + ede8c9b937d...e6d11e94edf gh/BowenBao/318/orig    -> origin/gh/BowenBao/318/orig  (forced update)
   59f89ee2bcc..1bd184228ba  gh/andrewlee302/2/base  -> origin/gh/andrewlee302/2/base
   a5d2e1f7bbc..787b2b43edd  gh/andrewlee302/2/head  -> origin/gh/andrewlee302/2/head
 + 5efd9596d56...f4f56e87268 gh/andrewlee302/2/orig  -> origin/gh/andrewlee302/2/orig  (forced update)
   3324cedf683..885abd9be93  gh/andrewor14/43/base   -> origin/gh/andrewor14/43/base
   b23eb432edb..89df0e488a9  gh/andrewor14/43/head   -> origin/gh/andrewor14/43/head
 + 43877f7b15d...0eeb1a9caa0 gh/andrewor14/43/orig   -> origin/gh/andrewor14/43/orig  (forced update)
   5dcc2908b70..add4560a427  gh/andrewor14/44/base   -> origin/gh/andrewor14/44/base
   91a2f3c4684..dfa1118c902  gh/andrewor14/44/head   -> origin/gh/andrewor14/44/head
 + 7e205fe1a06...81b631ebe21 gh/andrewor14/44/orig   -> origin/gh/andrewor14/44/orig  (forced update)
   5b4c4b4e2af..2a6c66cba3e  gh/bdhirsh/484/base     -> origin/gh/bdhirsh/484/base
   0e99eb700c3..b4bf88c975a  gh/bdhirsh/484/head     -> origin/gh/bdhirsh/484/head
 + 8d8da983b72...029bc5af8b1 gh/bdhirsh/484/orig     -> origin/gh/bdhirsh/484/orig  (forced update)
   3b6b5faf1a3..21191ec1921  gh/drisspg/11/base      -> origin/gh/drisspg/11/base
   92148fe9b2a..f8891455233  gh/drisspg/11/head      -> origin/gh/drisspg/11/head
 + 2b58dff71a0...fa354c81d21 gh/drisspg/11/orig      -> origin/gh/drisspg/11/orig  (forced update)
   15fd7a7d45f..77eee3483aa  gh/eellison/543/base    -> origin/gh/eellison/543/base
   559a14c0591..ddec675c04a  gh/eellison/543/head    -> origin/gh/eellison/543/head
 + b9a624fb80f...987a030081d gh/eellison/543/orig    -> origin/gh/eellison/543/orig  (forced update)
   a093a6492cc..fce8796c5d3  gh/ezyang/2443/head     -> origin/gh/ezyang/2443/head
 + bef6160b920...c86716323d2 gh/ezyang/2443/orig     -> origin/gh/ezyang/2443/orig  (forced update)
   ee484b28275..05b51b3945c  gh/fduwjj/110/base      -> origin/gh/fduwjj/110/base
   590f4537b39..47662a926e4  gh/fduwjj/110/head      -> origin/gh/fduwjj/110/head
 + db504c041ec...4da29ca0aa9 gh/fduwjj/110/orig      -> origin/gh/fduwjj/110/orig  (forced update)
   404dc5d0119..5e31a443151  gh/fduwjj/113/base      -> origin/gh/fduwjj/113/base
   7547f693ec6..f1314660154  gh/fduwjj/113/head      -> origin/gh/fduwjj/113/head
 + b8aa5342d69...55a8fcb7944 gh/fduwjj/113/orig      -> origin/gh/fduwjj/113/orig  (forced update)
   d63789656ae..0c112f844b0  gh/jbschlosser/95/base  -> origin/gh/jbschlosser/95/base
   e5a183ac672..53391651a77  gh/jbschlosser/95/head  -> origin/gh/jbschlosser/95/head
 + e5a13c3ee35...e07dc6c2064 gh/jbschlosser/95/orig  -> origin/gh/jbschlosser/95/orig  (forced update)
   8320f8ca4e6..965e700b54f  gh/jbschlosser/96/base  -> origin/gh/jbschlosser/96/base
   750e5e711dc..577ebf22ff6  gh/jbschlosser/96/head  -> origin/gh/jbschlosser/96/head
 + bfb52cf9dfa...ddaff7b17d3 gh/jbschlosser/96/orig  -> origin/gh/jbschlosser/96/orig  (forced update)
   01aad3cc960..257d15d9848  gh/jerryzh168/932/head  -> origin/gh/jerryzh168/932/head
 + 2d653f5906a...ad0a48c3ae9 gh/jerryzh168/932/orig  -> origin/gh/jerryzh168/932/orig  (forced update)
   e5513373242..6e682e1d399  gh/muchulee8/14/base    -> origin/gh/muchulee8/14/base
   d4adce6f54c..a765ea9b8b3  gh/muchulee8/14/head    -> origin/gh/muchulee8/14/head
 + 978d65ffcfd...dc653d65044 gh/muchulee8/14/orig    -> origin/gh/muchulee8/14/orig  (forced update)
   1760519357f..254dddf42cb  gh/soulitzer/251/head   -> origin/gh/soulitzer/251/head
 + a23638e8de8...67cc2cf2591 gh/soulitzer/251/orig   -> origin/gh/soulitzer/251/orig  (forced update)
 * [new branch]              gh/ydwu4/42/base        -> origin/gh/ydwu4/42/base
 * [new branch]              gh/ydwu4/42/head        -> origin/gh/ydwu4/42/head
 * [new branch]              gh/ydwu4/42/orig        -> origin/gh/ydwu4/42/orig
error: cannot lock ref 'refs/remotes/origin/hoy/autotune/lanucher': 'refs/remotes/origin/hoy' exists; cannot create 'refs/remotes/origin/hoy/autotune/lanucher'
 ! [new branch]              hoy/autotune/lanucher   -> origin/hoy/autotune/lanucher  (unable to update local ref)
   f9f3cf34ca3..ec7a766ae24  mlazos/mutable          -> origin/mlazos/mutable
   fc98a589888..30309148495  palic_request           -> origin/palic_request
 * [new branch]              remove_global_ns        -> origin/remove_global_ns
 + 3963150e74c...a8b33d711bd update_submodule_FBGEMM -> origin/update_submodule_FBGEMM  (forced update)
   277474f1a00..2164598c405  viable/strict           -> origin/viable/strict
 * [new branch]              voz/serde               -> origin/voz/serde
   88d08e65d71..97f11d53dfd  zainr/td-class-metrics  -> origin/zainr/td-class-metrics
 * [new tag]                 ciflow/inductor/113814  -> ciflow/inductor/113814
 * [new tag]                 ciflow/inductor/113815  -> ciflow/inductor/113815
 * [new tag]                 ciflow/trunk/113697     -> ciflow/trunk/113697
 * [new tag]                 ciflow/trunk/113774     -> ciflow/trunk/113774
 * [new tag]                 ciflow/trunk/113813     -> ciflow/trunk/113813
 * [new tag]                 ciflow/trunk/113814     -> ciflow/trunk/113814
error: some local refs could not be updated; try running
 'git remote prune origin' to remove any old, conflicting branches

Details for Dev Infra team

Raised by workflow job

Kenshiro-28 · 2023-11-16T11:11:34Z

I tested torch 2.1.1 (released yesterday on Pypi) with Docker image python:3.12-slim

https://pypi.org/project/torch/

Still can't install it, I get this error:

ERROR: Could not find a version that satisfies the requirement torch (from versions: none)
ERROR: No matching distribution found for torch

I guess it's not including the new wheels yet.

albanD · 2023-11-16T14:20:11Z

@pytorchbot merge

albanD · 2023-11-16T14:21:15Z

@Kenshiro-28 not until this is merged and the nightly build is triggered to get it for the nightly install.
For release install, it will be included in the upcoming 2.2 in Jan (see dev-discuss forum for details on the timing).

pytorchmergebot · 2023-11-16T14:22:31Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

Kenshiro-28 · 2023-11-16T14:59:39Z

@Kenshiro-28 not until this is merged and the nightly build is triggered to get it for the nightly install. For release install, it will be included in the upcoming 2.2 in Jan (see dev-discuss forum for details on the timing).

Ok, thank you! :)

Follow up after pytorch/pytorch#112882. Please note conda-build and conda is not available yet for Python=3.12. Hence building wheels under Conda Python 3.9.

pytorch-bot bot added the topic: not user facing topic category label Nov 3, 2023

albanD added the ciflow/binaries Trigger all binary build and upload jobs on the PR label Nov 3, 2023

albanD changed the title ~~rebase~~ Add all 3.12 binary build. Let's see how it goes. V2 Nov 3, 2023

albanD added skip-pr-sanity-checks ciflow/binaries_wheel Trigger binary build and upload jobs for wheel on the PR and removed ciflow/binaries Trigger all binary build and upload jobs on the PR labels Nov 3, 2023

albanD force-pushed the 312_build_enable branch from 2a5be64 to bee9891 Compare November 10, 2023 17:29

albanD changed the title ~~Add all 3.12 binary build. Let's see how it goes. V2~~ Add all 3.12 binary build for wheel. Let's see how it goes. V2 Nov 10, 2023

albanD force-pushed the 312_build_enable branch 2 times, most recently from f113c2f to 4e411db Compare November 10, 2023 18:43

albanD added the with-ssh label Nov 10, 2023

albanD force-pushed the 312_build_enable branch 4 times, most recently from d675b6d to c4ed27d Compare November 13, 2023 16:45

github-actions bot added the module: dynamo label Nov 13, 2023

albanD force-pushed the 312_build_enable branch from 9fa2c2e to 56a0254 Compare November 14, 2023 20:08

This was referenced Nov 14, 2023

Changes needed for core enablement of 3.12 binaries pytorch/builder#1586

Merged

Pytorch for Python 3.12 not available #110436

Closed

albanD force-pushed the 312_build_enable branch from 56a0254 to 76ebd38 Compare November 15, 2023 14:44

albanD marked this pull request as ready for review November 15, 2023 14:45

albanD requested a review from a team as a code owner November 15, 2023 14:45

albanD requested a review from malfet November 15, 2023 14:45

albanD force-pushed the 312_build_enable branch from 76ebd38 to 434c4f0 Compare November 15, 2023 17:17

malfet approved these changes Nov 15, 2023

View reviewed changes

b-butler mentioned this pull request Nov 15, 2023

Add example of optimizing hyperparameters for handwriting recognition glotzerlab/signac-examples#57

Open

Burhan-Q mentioned this pull request Nov 15, 2023

Limit setup.py for python version ultralytics/ultralytics#5899

Closed

pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 15, 2023

pytorchmergebot added the merging label Nov 15, 2023

pytorchmergebot removed the merging label Nov 16, 2023

sammcj approved these changes Nov 16, 2023

View reviewed changes

albanD added 10 commits November 16, 2023 09:19

Only wheels

10aba76

use custom builder for now

06ad0a9

use proper branch for testing

de72229

Use proper builder branch for macos and windows as well.

1b92ea3

set minimum version for typing-extensions for 3.12

1cd4bb8

Fix compilation issues on macos and windows

a23440e

Wrong stub

205cf5f

Missing include

4849467

Add missing dependency on windows

ccbf4e5

Update to use main branch of builder

37f5ae4

albanD force-pushed the 312_build_enable branch from 434c4f0 to 37f5ae4 Compare November 16, 2023 14:20

pytorchmergebot added the merging label Nov 16, 2023

effigies mentioned this pull request Nov 16, 2023

CI: Test on Python 3.12 nipreps/mriqc#1156

Merged

pytorchmergebot added Merged and removed merging labels Nov 16, 2023

pytorchmergebot closed this in 25fb88c Nov 16, 2023

pmeier mentioned this pull request Nov 17, 2023

torch.compile introduces runtime dependency on setuptools or packaging #113940

Closed

atalman mentioned this pull request Nov 29, 2023

Add python 3.12 to wheel builds pytorch/test-infra#4768

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add all 3.12 binary build for wheel. Let's see how it goes. V2 #112882

Add all 3.12 binary build for wheel. Let's see how it goes. V2 #112882

albanD commented Nov 3, 2023 •

edited by pytorch-bot bot

pytorch-bot bot commented Nov 3, 2023 •

edited

albanD commented Nov 15, 2023

pytorchmergebot commented Nov 15, 2023

pytorchmergebot commented Nov 16, 2023

Kenshiro-28 commented Nov 16, 2023 •

edited

albanD commented Nov 16, 2023

albanD commented Nov 16, 2023

pytorchmergebot commented Nov 16, 2023

Kenshiro-28 commented Nov 16, 2023

Add all 3.12 binary build for wheel. Let's see how it goes. V2 #112882

Add all 3.12 binary build for wheel. Let's see how it goes. V2 #112882

Conversation

albanD commented Nov 3, 2023 • edited by pytorch-bot bot

pytorch-bot bot commented Nov 3, 2023 • edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/112882

✅ No Failures

albanD commented Nov 15, 2023

pytorchmergebot commented Nov 15, 2023

Merge started

pytorchmergebot commented Nov 16, 2023

Merge failed

Kenshiro-28 commented Nov 16, 2023 • edited

albanD commented Nov 16, 2023

albanD commented Nov 16, 2023

pytorchmergebot commented Nov 16, 2023

Merge started

Kenshiro-28 commented Nov 16, 2023

albanD commented Nov 3, 2023 •

edited by pytorch-bot bot

pytorch-bot bot commented Nov 3, 2023 •

edited

Kenshiro-28 commented Nov 16, 2023 •

edited