Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Back out "Support fp8 in AOTInductor + support optional<> in C ABI (#112527)" #113747

Closed
wants to merge 1 commit into from

Conversation

frank-wei
Copy link
Contributor

@frank-wei frank-wei commented Nov 15, 2023

…ytorch#112527)"

Test Plan: sandcastle

Differential Revision: D51330618
Copy link

pytorch-bot bot commented Nov 15, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/113747

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit fd31b3e with merge base 7f1eda8 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51330618

Copy link

This PR needs a release notes: label

If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@aakhundov
Copy link
Contributor

cc @int3 @ipiszy.

@facebook-github-bot
Copy link
Contributor

@pytorchbot merge -f 'Landed internally'

(Initiating merge automatically since Phabricator Diff has merged, using force because this PR might not pass merge_rules.json but landed internally)

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

int3 added a commit that referenced this pull request Dec 1, 2023
This is a backout of #113747 which reverted the above two commits.

[ghstack-poisoned]
int3 added a commit that referenced this pull request Dec 1, 2023
This is a backout of #113747 which reverted the above two commits.

ghstack-source-id: f5a794fdf03bbbccc8ad416d1f3960aa02052c6a
Pull Request resolved: #114974
int3 added a commit that referenced this pull request Dec 1, 2023
This is a backout of #113747 which reverted the above two commits.

[ghstack-poisoned]
int3 added a commit that referenced this pull request Dec 1, 2023
This is a backout of #113747 which reverted the above two commits.

ghstack-source-id: fecfab474deec140005a36f81fdd72b4528f9f26
Pull Request resolved: #114990
int3 added a commit that referenced this pull request Dec 2, 2023
…pport)"


This is a backout of #113747 which reverted the above two commits. Now that
#113997 has landed, this diff can be landed safely without breaking ABI compatibility.

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 aakhundov ColinPeppler

[ghstack-poisoned]
int3 added a commit that referenced this pull request Dec 2, 2023
This is a backout of #113747 which reverted the above two commits.

Pull Request resolved: #114974
ghstack-source-id: fecfab474deec140005a36f81fdd72b4528f9f26
pytorchmergebot pushed a commit that referenced this pull request Dec 2, 2023
…4974)

This is a backout of #113747 which reverted the above two commits. Now that
#113997 has landed, this diff can be landed safely without breaking ABI compatibility.

Pull Request resolved: #114974
Approved by: https://github.com/chenyang78
dmenig pushed a commit to dmenig/pytorch that referenced this pull request Dec 21, 2023
… support) (pytorch#114974)

This is a backout of pytorch#113747 which reverted the above two commits. Now that
pytorch#113997 has landed, this diff can be landed safely without breaking ABI compatibility.

Pull Request resolved: pytorch#114974
Approved by: https://github.com/chenyang78
dmenig pushed a commit to dmenig/pytorch that referenced this pull request Dec 21, 2023
… support) (pytorch#114974)

This is a backout of pytorch#113747 which reverted the above two commits. Now that
pytorch#113997 has landed, this diff can be landed safely without breaking ABI compatibility.

Pull Request resolved: pytorch#114974
Approved by: https://github.com/chenyang78
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants