Don't toggle torch logger to NOTSET if it is not set; always use pre-existing #113842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…existing This is kind of hard to test. Signed-off-by: Edward Z. Yang <ezyang@meta.com> [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/113842
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit cb04b7c with merge base cdc9a05 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
ezyang
added a commit
that referenced
this pull request
Nov 16, 2023
…existing This is kind of hard to test. Signed-off-by: Edward Z. Yang <ezyangmeta.com> ghstack-source-id: 0dabf46f6ff70c50cb789c8a237fd98117604b61 Pull Request resolved: #113842
github-actions
bot
requested review from
albanD,
antoniojkim,
bdhirsh,
miladm,
SherlockNoMad,
voznesenskym and
wconstab
wanchaol
approved these changes
Nov 16, 2023
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This is kind of hard to test.
Signed-off-by: Edward Z. Yang ezyang@meta.com