[dtensor] group dispatch unwrapping to a method #113846
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR group the dispatch unwrapping logic to a method, so that even custom handlers can reuses many parts of the dispatch logic to do custom things. [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/113846
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 1aef3e9 with merge base 277474f ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
wanchaol
added a commit
that referenced
this pull request
Nov 16, 2023
This PR group the dispatch unwrapping logic to a method, so that even custom handlers can reuses many parts of the dispatch logic to do custom things. ghstack-source-id: 714aceb4243c76110afae73c602d2359d7b9a799 Pull Request resolved: #113846
This PR group the dispatch unwrapping logic to a method, so that even custom handlers can reuses many parts of the dispatch logic to do custom things. [ghstack-poisoned]
wanchaol
added a commit
that referenced
this pull request
Nov 16, 2023
This PR group the dispatch unwrapping logic to a method, so that even custom handlers can reuses many parts of the dispatch logic to do custom things. ghstack-source-id: 779f876bca200f7d99a1527105a137cb18907171 Pull Request resolved: #113846
wanchaol
added
module: distributed
ciflow/trunk
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
albanD
added
oncall: distributed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This PR group the dispatch unwrapping logic to a method, so that even
custom handlers can reuses many parts of the dispatch logic to do custom
things.
cc @mrshenli @pritamdamania87 @zhaojuanmao @satgera @rohan-varma @gqchen @aazzolini @osalpekar @jiayisuse @H-Huang @kwen2501 @awgu @penguinwu @fegin @XilunWu @fduwjj @wz337 @tianyu-l @wconstab @yf225 @kiukchung @d4l3k @LucasLLC