Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[inductor max autotune] Log but continue on errors during autotuning benchmark #113891

Closed
wants to merge 22 commits into from

Conversation

kadeng
Copy link
Contributor

@kadeng kadeng commented Nov 16, 2023

Stack from ghstack (oldest at bottom):

If one of several choices within max autotune fails with a compilation error or runtime error, the entire model compilation fails.

This changes the behavior, such that an error is being logged, but the model compilation may continue as long as valid choices remain.

…benchmark

If one of several choices within max autotune fails with a compilation error or runtime error, the entire model compilation fails.

This changes the behavior, such that an error is being logged, but the model compilation may continue as long as valid choices remain.

[ghstack-poisoned]
Copy link

pytorch-bot bot commented Nov 16, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/113891

Note: Links to docs will display an error until the docs builds have been completed.

❌ 15 New Failures, 11 Unrelated Failures

As of commit 01012b0 with merge base afe6d27 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

…autotuning benchmark"

If one of several choices within max autotune fails with a compilation error or runtime error, the entire model compilation fails.

This changes the behavior, such that an error is being logged, but the model compilation may continue as long as valid choices remain.

[ghstack-poisoned]
kadeng added a commit that referenced this pull request Nov 16, 2023
…benchmark

If one of several choices within max autotune fails with a compilation error or runtime error, the entire model compilation fails.

This changes the behavior, such that an error is being logged, but the model compilation may continue as long as valid choices remain.

ghstack-source-id: 67651be1e01ba5ec9732ad787bc2ca738ef287cf
Pull Request resolved: #113891
…autotuning benchmark"

If one of several choices within max autotune fails with a compilation error or runtime error, the entire model compilation fails.

This changes the behavior, such that an error is being logged, but the model compilation may continue as long as valid choices remain.

[ghstack-poisoned]
…autotuning benchmark"

If one of several choices within max autotune fails with a compilation error or runtime error, the entire model compilation fails.

This changes the behavior, such that an error is being logged, but the model compilation may continue as long as valid choices remain.

[ghstack-poisoned]
…autotuning benchmark"

If one of several choices within max autotune fails with a compilation error or runtime error, the entire model compilation fails.

This changes the behavior, such that an error is being logged, but the model compilation may continue as long as valid choices remain.

[ghstack-poisoned]
…autotuning benchmark"

If one of several choices within max autotune fails with a compilation error or runtime error, the entire model compilation fails.

This changes the behavior, such that an error is being logged, but the model compilation may continue as long as valid choices remain.

[ghstack-poisoned]
…autotuning benchmark"

If one of several choices within max autotune fails with a compilation error or runtime error, the entire model compilation fails.

This changes the behavior, such that an error is being logged, but the model compilation may continue as long as valid choices remain.

[ghstack-poisoned]
…autotuning benchmark"

If one of several choices within max autotune fails with a compilation error or runtime error, the entire model compilation fails.

This changes the behavior, such that an error is being logged, but the model compilation may continue as long as valid choices remain.

[ghstack-poisoned]
…autotuning benchmark"

If one of several choices within max autotune fails with a compilation error or runtime error, the entire model compilation fails.

This changes the behavior, such that an error is being logged, but the model compilation may continue as long as valid choices remain.

[ghstack-poisoned]
…autotuning benchmark"

If one of several choices within max autotune fails with a compilation error or runtime error, the entire model compilation fails.

This changes the behavior, such that an error is being logged, but the model compilation may continue as long as valid choices remain.

[ghstack-poisoned]
…autotuning benchmark"

If one of several choices within max autotune fails with a compilation error or runtime error, the entire model compilation fails.

This changes the behavior, such that an error is being logged, but the model compilation may continue as long as valid choices remain.

[ghstack-poisoned]
…autotuning benchmark"

If one of several choices within max autotune fails with a compilation error or runtime error, the entire model compilation fails.

This changes the behavior, such that an error is being logged, but the model compilation may continue as long as valid choices remain.

[ghstack-poisoned]
…autotuning benchmark"

If one of several choices within max autotune fails with a compilation error or runtime error, the entire model compilation fails.

This changes the behavior, such that an error is being logged, but the model compilation may continue as long as valid choices remain.

[ghstack-poisoned]
…autotuning benchmark"

If one of several choices within max autotune fails with a compilation error or runtime error, the entire model compilation fails.

This changes the behavior, such that an error is being logged, but the model compilation may continue as long as valid choices remain.

[ghstack-poisoned]
…autotuning benchmark"

If one of several choices within max autotune fails with a compilation error or runtime error, the entire model compilation fails.

This changes the behavior, such that an error is being logged, but the model compilation may continue as long as valid choices remain.

[ghstack-poisoned]
…autotuning benchmark"

If one of several choices within max autotune fails with a compilation error or runtime error, the entire model compilation fails.

This changes the behavior, such that an error is being logged, but the model compilation may continue as long as valid choices remain.

[ghstack-poisoned]
…autotuning benchmark"

If one of several choices within max autotune fails with a compilation error or runtime error, the entire model compilation fails.

This changes the behavior, such that an error is being logged, but the model compilation may continue as long as valid choices remain.

[ghstack-poisoned]
…autotuning benchmark"

If one of several choices within max autotune fails with a compilation error or runtime error, the entire model compilation fails.

This changes the behavior, such that an error is being logged, but the model compilation may continue as long as valid choices remain.

[ghstack-poisoned]
…autotuning benchmark"

If one of several choices within max autotune fails with a compilation error or runtime error, the entire model compilation fails.

This changes the behavior, such that an error is being logged, but the model compilation may continue as long as valid choices remain.

[ghstack-poisoned]
…autotuning benchmark"

If one of several choices within max autotune fails with a compilation error or runtime error, the entire model compilation fails.

This changes the behavior, such that an error is being logged, but the model compilation may continue as long as valid choices remain.

[ghstack-poisoned]
…autotuning benchmark"

If one of several choices within max autotune fails with a compilation error or runtime error, the entire model compilation fails.

This changes the behavior, such that an error is being logged, but the model compilation may continue as long as valid choices remain.

[ghstack-poisoned]
…autotuning benchmark"

If one of several choices within max autotune fails with a compilation error or runtime error, the entire model compilation fails.

This changes the behavior, such that an error is being logged, but the model compilation may continue as long as valid choices remain.

[ghstack-poisoned]
@kadeng
Copy link
Contributor Author

kadeng commented Dec 15, 2023

Moved to a (draft) feature branch, see #115919

@kadeng kadeng closed this Dec 15, 2023
@facebook-github-bot facebook-github-bot deleted the gh/kadeng/27/head branch January 14, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant