[AOTInductor] Use ProxyExecutor for aten op if c-shim is missing #113918
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/113918
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (2 Unrelated Failures)As of commit e74ebbe with merge base 631fb33 ( BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
This pull request was exported from Phabricator. Differential Revision: D51417683 |
SherlockNoMad
force-pushed
the
export-D51417683
branch
from
0216986
to
3de10e3
Compare
…orch#113918) Summary: As discussed in the meeting, we are inverting the policy on the use of proxy executor for aten fallbacks. By default, aten fallback ops will use proxy executor, unless a c-shim is available. Added test for aten.sort and aten.index.Tensor, as they are now runnable with proxy executor. Test Plan: CIs Differential Revision: D51417683
|
This pull request was exported from Phabricator. Differential Revision: D51417683 |
| @@ -973,6 +973,7 @@ def forward(self, x): | |||
| example_inputs = (torch.randn(8, 4, 4, device=self.device),) | |||
| self.check_model(Model(), example_inputs) | |||
|
|
|||
| @unittest.skipIf(IS_FBCODE, "Not runnable in fbcode") | |||
There was a problem hiding this comment.
Wondering why this test is not runnable in fbcode? Does the change of using ProxyExecutor as fallback by default affect this test? Thanks.
There was a problem hiding this comment.
In OSS ABI mode, this test is failing due to aten.index.Tensor missing c-shim, this is why we have it as xfail in the first place.
In fbcode ABI mode, this is failing due to extern_kernel_serializer not populated in AOTInductorModelRunner. I tried to add it, but this introduces dependency of fbcode module ‘deeplearning.aot_inductor.extern_node_thrift_serializer’ into an oss test file, which buck build failed.
As a result, I added the same test case to test_custom_op.py, as you can see in the fbcode diff.
SherlockNoMad
force-pushed
the
export-D51417683
branch
from
3de10e3
to
ccb4dcf
Compare
…orch#113918) Summary: As discussed in the meeting, we are inverting the policy on the use of proxy executor for aten fallbacks. By default, aten fallback ops will use proxy executor, unless a c-shim is available. Added test for aten.sort and aten.index.Tensor, as they are now runnable with proxy executor. Test Plan: CIs Reviewed By: chenyang78 Differential Revision: D51417683
|
This pull request was exported from Phabricator. Differential Revision: D51417683 |
SherlockNoMad
force-pushed
the
export-D51417683
branch
from
ccb4dcf
to
b4bfa08
Compare
…orch#113918) Summary: As discussed in the meeting, we are inverting the policy on the use of proxy executor for aten fallbacks. By default, aten fallback ops will use proxy executor, unless a c-shim is available. Added test for aten.sort and aten.index.Tensor, as they are now runnable with proxy executor. Test Plan: CIs Reviewed By: chenyang78 Differential Revision: D51417683
|
This pull request was exported from Phabricator. Differential Revision: D51417683 |
SherlockNoMad
force-pushed
the
export-D51417683
branch
from
b4bfa08
to
7ed99f8
Compare
…orch#113918) Summary: As discussed in the meeting, we are inverting the policy on the use of proxy executor for aten fallbacks. By default, aten fallback ops will use proxy executor, unless a c-shim is available. Added test for aten.sort and aten.index.Tensor, as they are now runnable with proxy executor. Test Plan: CIs Reviewed By: chenyang78 Differential Revision: D51417683
|
This pull request was exported from Phabricator. Differential Revision: D51417683 |
SherlockNoMad
force-pushed
the
export-D51417683
branch
from
7ed99f8
to
9ce5341
Compare
…orch#113918) Summary: As discussed in the meeting, we are inverting the policy on the use of proxy executor for aten fallbacks. By default, aten fallback ops will use proxy executor, unless a c-shim is available. Added test for aten.sort and aten.index.Tensor, as they are now runnable with proxy executor. Test Plan: CIs Reviewed By: chenyang78 Differential Revision: D51417683
|
This pull request was exported from Phabricator. Differential Revision: D51417683 |
…orch#113918) Summary: As discussed in the meeting, we are inverting the policy on the use of proxy executor for aten fallbacks. By default, aten fallback ops will use proxy executor, unless a c-shim is available. Added test for aten.sort and aten.index.Tensor, as they are now runnable with proxy executor. Test Plan: CIs Reviewed By: chenyang78 Differential Revision: D51417683
SherlockNoMad
force-pushed
the
export-D51417683
branch
from
9ce5341
to
e74ebbe
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51417683 |
|
@pytorchbot merge (Initiating merge automatically since Phabricator Diff has merged) |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Summary:
As discussed in the meeting, we are inverting the policy on the use of proxy executor for aten fallbacks.
By default, aten fallback ops will use proxy executor, unless a c-shim is available.
Test Plan: CIs
Differential Revision: D51417683
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @peterbell10 @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @aakhundov @ColinPeppler