Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow for calling lift_fresh_copy manually #113923

Closed
wants to merge 3 commits into from
Closed

Allow for calling lift_fresh_copy manually #113923

wants to merge 3 commits into from

Conversation

ezyang
Copy link
Contributor

@ezyang ezyang commented Nov 17, 2023 •
edited by pytorch-bot bot
Loading

Stack from ghstack (oldest at bottom):

In this case, the input could be fake! Just treat it normally in that case.

Fixes #113331

Signed-off-by: Edward Z. Yang ezyang@meta.com

cc @avikchaudhuri @gmagogsfm @zhxchen17 @tugsbayasgalan @angelayi @suo @ydwu4

@ezyang
Allow for calling lift_fresh_copy manually
dc251bd 
In this case, the input could be fake!  Just treat it normally in that case.

Fixes #113331

Signed-off-by: Edward Z. Yang <ezyang@meta.com>

[ghstack-poisoned]
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Nov 17, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/113923

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (8 Unrelated Failures)

As of commit c542485 with merge base 09fe362 (image):

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@albanD albanD removed their request for review November 17, 2023 14:36
@ezyang
Update on "Allow for calling lift_fresh_copy manually"
049520a 
In this case, the input could be fake!  Just treat it normally in that case.

Fixes #113331

Signed-off-by: Edward Z. Yang <ezyangmeta.com>

cc avikchaudhuri gmagogsfm zhxchen17 tugsbayasgalan angelayi suo ydwu4

[ghstack-poisoned]
@ezyang ezyang added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 17, 2023
ezyang added a commit that referenced this pull request Nov 17, 2023
@ezyang
Allow for calling lift_fresh_copy manually
6698b0f 
In this case, the input could be fake!  Just treat it normally in that case.

Fixes #113331

Signed-off-by: Edward Z. Yang <ezyangmeta.com>

ghstack-source-id: 856afda31e24d4b5cba24b039d31688e7e7c58e0
Pull Request resolved: #113923
@ezyang
Copy link
Contributor Author

ezyang commented Nov 17, 2023

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: This PR needs a release notes: label
If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Details for Dev Infra team Raised by workflow job

leslie-fang-intel
leslie-fang-intel reviewed Nov 18, 2023
View reviewed changes
test/export/test_export.py

m = M().eval()
# res_ref = m(tensor_cpu, mask_cpu)
# print("res_ref is: {}".format(res_ref), flush=True)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe delete these comments? Sorry, I left it in the example code in the issue.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought they were good comments 📦

@ezyang ezyang added release notes: composability release notes category topic: bug fixes topic category labels Nov 18, 2023
@ezyang
Copy link
Contributor Author

ezyang commented Nov 18, 2023

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: Command git -C /home/runner/work/pytorch/pytorch cherry-pick -x 6698b0fcbc675367a3ac23755324b36387a0cd3e returned non-zero exit code 1

Auto-merging test/export/test_export.py
CONFLICT (content): Merge conflict in test/export/test_export.py
Auto-merging torch/_subclasses/fake_tensor.py
error: could not apply 6698b0fcbc6... Allow for calling lift_fresh_copy manually
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
Details for Dev Infra team Raised by workflow job

@ezyang
Update on "Allow for calling lift_fresh_copy manually"
c542485 
In this case, the input could be fake!  Just treat it normally in that case.

Fixes #113331

Signed-off-by: Edward Z. Yang <ezyangmeta.com>

cc avikchaudhuri gmagogsfm zhxchen17 tugsbayasgalan angelayi suo ydwu4

[ghstack-poisoned]
ezyang added a commit that referenced this pull request Nov 19, 2023
@ezyang
Allow for calling lift_fresh_copy manually
47d6b2e 
In this case, the input could be fake!  Just treat it normally in that case.

Fixes #113331

Signed-off-by: Edward Z. Yang <ezyangmeta.com>

ghstack-source-id: ec7d3cf361746fd3369a3b920d09da922417466a
Pull Request resolved: #113923
@ezyang
Copy link
Contributor Author

ezyang commented Nov 19, 2023

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@facebook-github-bot facebook-github-bot deleted the gh/ezyang/2453/head branch November 22, 2023 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eellison eellison eellison approved these changes

@bdhirsh bdhirsh bdhirsh approved these changes

@leslie-fang-intel leslie-fang-intel leslie-fang-intel approved these changes

@antoniojkim antoniojkim Awaiting requested review from antoniojkim

@miladm miladm Awaiting requested review from miladm

@SherlockNoMad SherlockNoMad Awaiting requested review from SherlockNoMad

@voznesenskym voznesenskym Awaiting requested review from voznesenskym

@wconstab wconstab Awaiting requested review from wconstab

Assignees
No one assigned
Labels
ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: composability release notes category topic: bug fixes topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ezyang @pytorchmergebot @eellison @bdhirsh @leslie-fang-intel