[Inductor] Support ReinterpretView in inductor codegen #113967
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/113967
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 732297e with merge base 7c35874 ( BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
oulgen
added a commit
that referenced
this pull request
Nov 17, 2023
ghstack-source-id: 500d7cb4d7b5af7aa8d6a982e66dd5cfe138edda Pull Request resolved: #113967
oulgen
added
ciflow/trunk
|
What is this for? |
Using native triton kernels with the jagged MRS kernels |
eellison
reviewed
Nov 17, 2023
I did add a test already? is that not enough? torch.empty_like ends up creating a |
aakhundov
approved these changes
Nov 18, 2023
pytorchmergebot
pushed a commit
that referenced
this pull request
Nov 18, 2023
…st (#114002) Prior to this PR, autotuned arguments could only be at the back of the argument list. This is an inductor limitation and not triton limitation. Fixing this allows more MRS kernels to use user defined triton kernels. Pull Request resolved: #114002 Approved by: https://github.com/aakhundov ghstack dependencies: #113967
oulgen
added a commit
that referenced
this pull request
Nov 20, 2023
#113967 added support for ReinterpretView but it turnes out we codegen it differently in abi compat mode. This PR adds support for abi compat mode as well. [ghstack-poisoned]
oulgen
added a commit
that referenced
this pull request
Nov 21, 2023
#113967 added support for ReinterpretView but it turnes out we codegen it differently in abi compat mode. This PR adds support for abi compat mode as well. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 aakhundov ColinPeppler [ghstack-poisoned]
oulgen
added a commit
that referenced
this pull request
Nov 21, 2023
#113967 added support for ReinterpretView but it turnes out we codegen it differently in abi compat mode. This PR adds support for abi compat mode as well. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 aakhundov ColinPeppler [ghstack-poisoned]
pytorchmergebot
pushed a commit
that referenced
this pull request
Nov 21, 2023
#113967 added support for ReinterpretView but it turnes out we codegen it differently in abi compat mode. This PR adds support for abi compat mode as well. Pull Request resolved: #114169 Approved by: https://github.com/aakhundov
oulgen
added a commit
that referenced
this pull request
Nov 23, 2023
#113967 added support for ReinterpretView but it turnes out we codegen it differently in abi compat mode. This PR adds support for abi compat mode as well. [ghstack-poisoned]
oulgen
added a commit
that referenced
this pull request
Nov 23, 2023
#113967 added support for ReinterpretView but it turnes out we codegen it differently in abi compat mode. This PR adds support for abi compat mode as well. [ghstack-poisoned]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Adding support for ReinterpretView in inductor so that jagged MRS kernels can use native triton kernels
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @peterbell10 @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @aakhundov @ColinPeppler