Add mechanism for make_fx to not error on data-dependent-ops #114129
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm looking for a make_fx(tracing_mode=real) that doesn't error out on data-dependent operations. This PR adds a flag to do that. We use this to help implement offline generation, but this is useful by itself: sometimes we want to trace a function with real tensors and don't care if we bake values in (because we just want to see what happened). Test Plan: - new test [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/114129
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 894d27b with merge base f36d09f ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
zou3519
added a commit
that referenced
this pull request
Nov 20, 2023
I'm looking for a make_fx(tracing_mode=real) that doesn't error out on data-dependent operations. This PR adds a flag to do that. We use this to help implement offline generation, but this is useful by itself: sometimes we want to trace a function with real tensors and don't care if we bake values in (because we just want to see what happened). Test Plan: - new test ghstack-source-id: 09593c96e741e2a40c7901102ffbbc05ca6aa5f3 Pull Request resolved: #114129
ezyang
approved these changes
Nov 20, 2023
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
I'm looking for a make_fx(tracing_mode=real) that doesn't error out on
data-dependent operations. This PR adds a flag to do that. We use this
to help implement offline generation, but this is useful by itself:
sometimes we want to trace a function with real tensors and don't care
if we bake values in (because we just want to see what happened).
Test Plan: