Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DTensor] Replaced neg dim normalization with assert in helper #114141

Closed
wants to merge 2 commits into from
Closed

[DTensor] Replaced neg dim normalization with assert in helper #114141

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a62099f
[DTensor] Replaced neg dim normalization with assert in global info
awgu Nov 20, 2023
c9b564d
Update on "[DTensor] Replaced neg dim normalization with assert in he…
awgu Nov 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions torch/distributed/_tensor/_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,8 +145,10 @@ def compute_global_tensor_info(
if placement.is_shard():
shard_placement = cast(Shard, placement)
if shard_placement.dim < 0:
# normalize shard dim to be positive
shard_placement.dim += len(tensor_shape)
raise AssertionError(
"Shard placements should have negative dims normalized in "
f"the user-facing APIs: {shard_placement}"
)
shard_dim = shard_placement.dim

assert (
Expand Down
Loading