[dtensor] enable adagrad foreach support #114151
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR enables the adagrad foreach mode support [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/114151
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit ce2aac3 with merge base edc5ae3 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Nov 20, 2023
wanchaol
added
module: distributed
release notes: distributed (dtensor)
This PR enables the adagrad foreach mode support cc H-Huang awgu kwen2501 fegin fduwjj wz337 wconstab mrshenli zhaojuanmao rohan-varma kiukchung d4l3k lucasllc XilunWu [ghstack-poisoned]
|
Thanks for addressing the comments. I think we're good to go! |
pytorchmergebot
pushed a commit
that referenced
this pull request
Nov 21, 2023
as titled Pull Request resolved: #114152 Approved by: https://github.com/XilunWu ghstack dependencies: #114149, #114150, #114151
albanD
added
oncall: distributed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This PR enables the adagrad foreach mode support
cc @mrshenli @pritamdamania87 @zhaojuanmao @satgera @rohan-varma @gqchen @aazzolini @osalpekar @jiayisuse @H-Huang @kwen2501 @awgu @penguinwu @fegin @XilunWu @fduwjj @wz337 @tianyu-l @wconstab @yf225 @kiukchung @d4l3k @LucasLLC