Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly codegen math.inf in Inductor #114159

Closed
wants to merge 3 commits into from
Closed

Correctly codegen math.inf in Inductor #114159

wants to merge 3 commits into from

Conversation

ezyang
Copy link
Contributor

@ezyang ezyang commented Nov 20, 2023 •
edited by pytorch-bot bot

@ezyang
Correctly codegen math.inf in Inductor
1fd67ce 
Signed-off-by: Edward Z. Yang <ezyang@meta.com>

[ghstack-poisoned]
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Nov 20, 2023 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/114159

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 0c762b9 with merge base 18e1a37 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

ezyang added a commit that referenced this pull request Nov 20, 2023
@ezyang
Correctly codegen math.inf in Inductor
796ab2e 
Signed-off-by: Edward Z. Yang <ezyangmeta.com>

ghstack-source-id: fd0b5ed898d38d0ba9512e643d1621980a24c89e
Pull Request resolved: #114159
@albanD albanD removed their request for review November 20, 2023 21:41
@ezyang
Update on "Correctly codegen math.inf in Inductor"
16b0a7e 
Signed-off-by: Edward Z. Yang <ezyangmeta.com>

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 aakhundov ColinPeppler

[ghstack-poisoned]
ezyang added a commit that referenced this pull request Nov 21, 2023
@ezyang
Correctly codegen math.inf in Inductor
ed45eb2 
Signed-off-by: Edward Z. Yang <ezyangmeta.com>

ghstack-source-id: d951d5725d23589e494b79b8332355421e4c1a7d
Pull Request resolved: #114159
lezcano
lezcano approved these changes Nov 21, 2023
View reviewed changes
Copy link
Collaborator

@lezcano lezcano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth doing the same thing for NegativeInfinity now that we are at it, but LGTM.

@ezyang
Update on "Correctly codegen math.inf in Inductor"
0c762b9 
Signed-off-by: Edward Z. Yang <ezyangmeta.com>

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx peterbell10 ipiszy yf225 chenyang78 kadeng muchulee8 aakhundov ColinPeppler

[ghstack-poisoned]
ezyang added a commit that referenced this pull request Nov 21, 2023
@ezyang
Correctly codegen math.inf in Inductor
c557a4d 
Signed-off-by: Edward Z. Yang <ezyangmeta.com>

ghstack-source-id: ef1607344ef8ecfcd72d883cc111e16ea52fce23
Pull Request resolved: #114159
@ezyang
Copy link
Contributor Author

ezyang commented Nov 21, 2023

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 21, 2023
@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: This PR needs a release notes: label
If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Details for Dev Infra team Raised by workflow job

@ezyang
Copy link
Contributor Author

ezyang commented Nov 21, 2023

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@facebook-github-bot facebook-github-bot deleted the gh/ezyang/2466/head branch November 25, 2023 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lezcano lezcano lezcano approved these changes

@antoniojkim antoniojkim Awaiting requested review from antoniojkim

@bdhirsh bdhirsh Awaiting requested review from bdhirsh

@miladm miladm Awaiting requested review from miladm

@SherlockNoMad SherlockNoMad Awaiting requested review from SherlockNoMad

@voznesenskym voznesenskym Awaiting requested review from voznesenskym

@wconstab wconstab Awaiting requested review from wconstab

@Chillee Chillee Awaiting requested review from Chillee

@aakhundov aakhundov Awaiting requested review from aakhundov

Assignees
No one assigned
Labels
ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: inductor release notes: inductor topic: bug fixes topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ezyang @pytorchmergebot @lezcano