[FSDP] Added DDP parity test for CPU training #114372
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/114372
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 99e090b with merge base 33fad1c ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
awgu
added a commit
that referenced
this pull request
Nov 22, 2023
ghstack-source-id: 1f7d5f479651c241edebe71799f60c9a0d328df9 Pull Request resolved: #114372
[ghstack-poisoned]
awgu
added a commit
that referenced
this pull request
Nov 22, 2023
ghstack-source-id: 3e71276572236796a9a969d8b4f844e8743e15bf Pull Request resolved: #114372
This is a follow-up to #112145 to include a numerical parity test with DDP for CPU training. ``` python -m pytest test/distributed/fsdp/test_fsdp_misc.py -k test_fsdp_cpu_training -s ``` We should follow-up on https://github.com/pytorch/pytorch/pull/112145/files#r1375102283 at some point too. [ghstack-poisoned]
awgu
added a commit
that referenced
this pull request
Nov 22, 2023
ghstack-source-id: 95fabf859329e4461128584e4c9c4b62b090b83f Pull Request resolved: #114372
This is a follow-up to #112145 to include a numerical parity test with DDP for CPU training. ``` python -m pytest test/distributed/fsdp/test_fsdp_misc.py -k test_fsdp_cpu_training -s ``` We should follow-up on https://github.com/pytorch/pytorch/pull/112145/files#r1375102283 at some point too. cc H-Huang kwen2501 wanchaol fegin fduwjj wz337 wconstab mrshenli zhaojuanmao rohan-varma kiukchung d4l3k lucasllc XilunWu tianyu-l [ghstack-poisoned]
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
This was referenced Nov 22, 2023
xunsongh
pushed a commit
to xunsongh/pytorch
that referenced
this pull request
Nov 24, 2023
This is a follow-up to pytorch#112145 to include a numerical parity test with DDP for CPU training. ``` python -m pytest test/distributed/fsdp/test_fsdp_misc.py -k test_fsdp_cpu_training -s ``` We should follow-up on https://github.com/pytorch/pytorch/pull/112145/files#r1375102283 at some point too. Pull Request resolved: pytorch#114372 Approved by: https://github.com/XilunWu
albanD
added
oncall: distributed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
dynamic=Falsefor compile tests #114390DTensorSpechash recomputation lazy #114379This is a follow-up to #112145 to include a numerical parity test with DDP for CPU training.
We should follow-up on https://github.com/pytorch/pytorch/pull/112145/files#r1375102283 at some point too.
cc @mrshenli @pritamdamania87 @zhaojuanmao @satgera @rohan-varma @gqchen @aazzolini @osalpekar @jiayisuse @H-Huang @kwen2501 @penguinwu @fegin @XilunWu @wanchaol @fduwjj @wz337 @tianyu-l @wconstab @yf225 @kiukchung @d4l3k @LucasLLC