[sparse][semi-structured][inductor] meta registrations for _cslt_sparse_mm + additional stride checking in test. #114685

jcaip · 2023-11-28T16:45:42Z

Stack from ghstack (oldest at bottom):

-> [sparse][semi-structured][inductor] meta registrations for _cslt_sparse_mm + additional stride checking in test. #114685

_cslt_sparse_mm + additional stride checking in test.

Summary:

This PR adds in meta registrations for _cslt_sparse_mm.

Based on the work @drisspg did
in #114370.

Additionally, it updates the tests by checking that the strides of the
spare result and the result returned by sparse+compile are the same, to
avoid errors like those found in

#114477.

Test Plan:

python test/test_sparse_semi_structred -k compile_cusparselt
python test/test_sparse_semi_structred -k compile_cutlass

Reviewers:

Subscribers:

Tasks:

Tags:

@drisspg

_cslt_sparse_mm + additional stride checking in test. Summary: This PR adds in meta registrations for _cslt_sparse_mm. Based on the work @drisspg did in #114370. Additionally, it updates the tests by checking that the strides of the spare result and the result returned by sparse+compile are the same, to avoid errors like those found in #114477. Test Plan: ``` python test/test_sparse_semi_structred -k compile_cusparselt python test/test_sparse_semi_structred -k compile_cutlass ``` Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]

pytorch-bot · 2023-11-28T16:45:46Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/114685

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 20461ef with merge base cef79c0 ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

_cslt_sparse_mm + additional stride checking in test. Summary: This PR adds in meta registrations for _cslt_sparse_mm. Based on the work drisspg did in #114370. Additionally, it updates the tests by checking that the strides of the spare result and the result returned by sparse+compile are the same, to avoid errors like those found in #114477. Test Plan: ``` python test/test_sparse_semi_structred -k compile_cusparselt python test/test_sparse_semi_structred -k compile_cutlass ``` Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: e2665c84b666464ee8f91ed8f1055d62a8e35799 Pull Request resolved: #114685

test/test_sparse_semi_structured.py

drisspg · 2023-11-28T17:17:33Z

torch/_meta_registrations.py

+    out_dtype: Optional[torch.dtype] = None,
+    transpose_result: bool = False,
+):
+    assert len(dense_B.shape) == 2, "cslt_sparse_mm only supports 2d inputs"


Maybe replicate the two other checks found in the C++ func

drisspg

I think it looks good modulo Daniels comments. If you wanted to get much more rigours checking for you, you can add a opinfo in common_method_invocations for the aten op and this will trigger many tests, one being the fake_tensor checking which ensures the meta registration is correct on your sample inputs

alexsamardzic

LGTM.

… _cslt_sparse_mm + additional stride checking in test." _cslt_sparse_mm + additional stride checking in test. Summary: This PR adds in meta registrations for _cslt_sparse_mm. Based on the work drisspg did in #114370. Additionally, it updates the tests by checking that the strides of the spare result and the result returned by sparse+compile are the same, to avoid errors like those found in #114477. Test Plan: ``` python test/test_sparse_semi_structred -k compile_cusparselt python test/test_sparse_semi_structred -k compile_cutlass ``` Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]

…se_mm + additional stride checking in test. Summary: This PR adds in meta registrations for _cslt_sparse_mm. Based on the work drisspg did in #114370. Additionally, it updates the tests by checking that the strides of the spare result and the result returned by sparse+compile are the same, to avoid errors like those found in #114477. Test Plan: ``` python test/test_sparse_semi_structred -k compile_cusparselt python test/test_sparse_semi_structred -k compile_cutlass ``` Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 91a64316a3399c2cb7082403547ee92f02f746a2 Pull Request resolved: #114685

… _cslt_sparse_mm + additional stride checking in test." _cslt_sparse_mm + additional stride checking in test. Summary: This PR adds in meta registrations for _cslt_sparse_mm. Based on the work drisspg did in #114370. Additionally, it updates the tests by checking that the strides of the spare result and the result returned by sparse+compile are the same, to avoid errors like those found in #114477. Test Plan: ``` python test/test_sparse_semi_structred -k compile_cusparselt python test/test_sparse_semi_structred -k compile_cutlass ``` Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]

…se_mm + additional stride checking in test. Summary: This PR adds in meta registrations for _cslt_sparse_mm. Based on the work drisspg did in #114370. Additionally, it updates the tests by checking that the strides of the spare result and the result returned by sparse+compile are the same, to avoid errors like those found in #114477. Test Plan: ``` python test/test_sparse_semi_structred -k compile_cusparselt python test/test_sparse_semi_structred -k compile_cutlass ``` Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: cc03188401100f6f1268844b99d1239d498dcead Pull Request resolved: #114685

jcaip · 2023-11-28T20:02:13Z

@pytorchbot merge

pytorchmergebot · 2023-11-28T20:04:17Z

Merge failed

Reason: Approval needed from one of the following:
chaekit, yozhu, khabinov, jg2912, anjali411, ...

Details for Dev Infra team

Raised by workflow job

Failing merge rule: Core Maintainers

jcaip · 2023-11-28T20:11:55Z

@pytorchbot merge

pytorchmergebot · 2023-11-28T20:13:49Z

Merge failed

Reason: This PR needs a release notes: label
If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Details for Dev Infra team

Raised by workflow job

jcaip · 2023-11-28T20:16:15Z

@pytorchbot merge

pytorchmergebot · 2023-11-28T20:19:21Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

@drisspg

…se_mm + additional stride checking in test. (pytorch#114685) _cslt_sparse_mm + additional stride checking in test. Summary: This PR adds in meta registrations for _cslt_sparse_mm. Based on the work @drisspg did in pytorch#114370. Additionally, it updates the tests by checking that the strides of the spare result and the result returned by sparse+compile are the same, to avoid errors like those found in pytorch#114477. Test Plan: ``` python test/test_sparse_semi_structred -k compile_cusparselt python test/test_sparse_semi_structred -k compile_cutlass ``` Reviewers: Subscribers: Tasks: Tags: Pull Request resolved: pytorch#114685 Approved by: https://github.com/alexsamardzic, https://github.com/drisspg

jcaip requested a review from drisspg November 28, 2023 16:46

jcaip changed the title ~~[sparse][semi-structured][inductor] meta registrations for~~ [sparse][semi-structured][inductor] meta registrations for _cslt_sparse_mm + additional stride checking in test. Nov 28, 2023

jcaip requested review from cpuhrsch and alexsamardzic November 28, 2023 16:46

danthe3rd reviewed Nov 28, 2023

View reviewed changes

test/test_sparse_semi_structured.py Show resolved Hide resolved

test/test_sparse_semi_structured.py Show resolved Hide resolved

drisspg reviewed Nov 28, 2023

View reviewed changes

alexsamardzic approved these changes Nov 28, 2023

View reviewed changes

pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 28, 2023

pytorchmergebot added the merging label Nov 28, 2023

pytorchmergebot removed the merging label Nov 28, 2023

drisspg approved these changes Nov 28, 2023

View reviewed changes

pytorchmergebot added the merging label Nov 28, 2023

pytorchmergebot removed the merging label Nov 28, 2023

jcaip added release notes: sparse release notes category release notes: inductor labels Nov 28, 2023

pytorchmergebot added the merging label Nov 28, 2023

pytorchmergebot added Merged and removed merging labels Nov 29, 2023

pytorchmergebot closed this in ae593d0 Nov 29, 2023

facebook-github-bot deleted the gh/jcaip/53/head branch December 2, 2023 15:28

jcaip mentioned this pull request Dec 4, 2023

Register Meta func for aten::_cslt_sparse_mm #114363

Closed

jcaip mentioned this pull request Dec 12, 2023

[Tracker] torch.sparse semi-structured 2.3 beta release #115662

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[sparse][semi-structured][inductor] meta registrations for _cslt_sparse_mm + additional stride checking in test. #114685

[sparse][semi-structured][inductor] meta registrations for _cslt_sparse_mm + additional stride checking in test. #114685

jcaip commented Nov 28, 2023 •

edited

pytorch-bot bot commented Nov 28, 2023 •

edited

drisspg Nov 28, 2023

drisspg left a comment

alexsamardzic left a comment

jcaip commented Nov 28, 2023

pytorchmergebot commented Nov 28, 2023

jcaip commented Nov 28, 2023

pytorchmergebot commented Nov 28, 2023

jcaip commented Nov 28, 2023

pytorchmergebot commented Nov 28, 2023

[sparse][semi-structured][inductor] meta registrations for _cslt_sparse_mm + additional stride checking in test. #114685

[sparse][semi-structured][inductor] meta registrations for _cslt_sparse_mm + additional stride checking in test. #114685

Conversation

jcaip commented Nov 28, 2023 • edited

pytorch-bot bot commented Nov 28, 2023 • edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/114685

✅ No Failures

drisspg Nov 28, 2023

Choose a reason for hiding this comment

drisspg left a comment

Choose a reason for hiding this comment

alexsamardzic left a comment

Choose a reason for hiding this comment

jcaip commented Nov 28, 2023

pytorchmergebot commented Nov 28, 2023

Merge failed

jcaip commented Nov 28, 2023

pytorchmergebot commented Nov 28, 2023

Merge failed

jcaip commented Nov 28, 2023

pytorchmergebot commented Nov 28, 2023

Merge started

jcaip commented Nov 28, 2023 •

edited

pytorch-bot bot commented Nov 28, 2023 •

edited