Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tgif] preserve non-forward method during torch package serialization #114702

Closed
wants to merge 1 commit into from
Closed

[tgif] preserve non-forward method during torch package serialization #114702

wants to merge 1 commit into from

Conversation

842974287
Copy link
Contributor

Reviewed By: terrycsy, sayitmemory

Differential Revision: D51607058

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Nov 28, 2023 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/114702

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 106941f with merge base b6df841 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: fx release notes category label Nov 28, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51607058

842974287 added a commit to 842974287/pytorch that referenced this pull request Nov 28, 2023
@842974287 @facebook-github-bot
[tgif] preserve non-forward method during torch package serialization (…
e77dee3 
…pytorch#114702)

Summary: Pull Request resolved: pytorch#114702

Reviewed By: terrycsy, sayitmemory

Differential Revision: D51607058
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51607058

842974287 added a commit to 842974287/pytorch that referenced this pull request Nov 29, 2023
@842974287 @facebook-github-bot
[tgif] preserve non-forward method during torch package serialization (…
e4f1e49 
…pytorch#114702)

Summary: Pull Request resolved: pytorch#114702

Reviewed By: terrycsy, sayitmemory

Differential Revision: D51607058
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51607058

842974287 added a commit to 842974287/pytorch that referenced this pull request Nov 29, 2023
@842974287 @facebook-github-bot
[tgif] preserve non-forward method during torch package serialization (…
6578897 
…pytorch#114702)

Summary:

bypass-github-export-checks
force-merge-on-github

Reviewed By: terrycsy, sayitmemory

Differential Revision: D51607058
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51607058

houseroad
houseroad approved these changes Nov 29, 2023
View reviewed changes
Copy link
Member

@houseroad houseroad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Can we add a unittest?

842974287 added a commit to 842974287/pytorch that referenced this pull request Nov 29, 2023
@842974287 @facebook-github-bot
[tgif] preserve non-forward method during torch package serialization (…
2096a5e 
…pytorch#114702)

Summary:

bypass-github-export-checks
force-merge-on-github

Reviewed By: terrycsy, houseroad, sayitmemory

Differential Revision: D51607058
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51607058

@842974287 @facebook-github-bot
[tgif] preserve non-forward method during torch package serialization (…
106941f 
…pytorch#114702)

Summary:

bypass-github-export-checks
force-merge-on-github

Reviewed By: terrycsy, houseroad, sayitmemory

Differential Revision: D51607058
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51607058

@facebook-github-bot
Copy link
Contributor

@pytorchbot merge -f 'Landed internally'

(Initiating merge automatically since Phabricator Diff has merged, using force because this PR might not pass merge_rules.json but landed internally)

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

hyperfraise pushed a commit to hyperfraise/pytorch that referenced this pull request Dec 21, 2023
@842974287 @hyperfraise
[tgif] preserve non-forward method during torch package serialization (…
86c870e 
…pytorch#114702)

Reviewed By: terrycsy, sayitmemory

Differential Revision: D51607058

Pull Request resolved: pytorch#114702
Approved by: https://github.com/houseroad
hyperfraise pushed a commit to hyperfraise/pytorch that referenced this pull request Dec 21, 2023
@842974287 @hyperfraise
[tgif] preserve non-forward method during torch package serialization (…
f00e049 
…pytorch#114702)

Reviewed By: terrycsy, sayitmemory

Differential Revision: D51607058

Pull Request resolved: pytorch#114702
Approved by: https://github.com/houseroad
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@houseroad houseroad houseroad approved these changes

@zyan0 zyan0 Awaiting requested review from zyan0

@Chillee Chillee Awaiting requested review from Chillee

Assignees
No one assigned
Labels
fb-exported Merged release notes: fx release notes category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@842974287 @facebook-github-bot @pytorchmergebot @houseroad