Remove confusing warning message from SDPA about mask alignment #114909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/114909
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 1288e96 with merge base 7c1a501 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
#110734 Maybe we can add back in the warning here even though that should probs be used for debugging and not really for performance checks |
Chillee
approved these changes
Nov 30, 2023
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
dmenig
pushed a commit
to dmenig/pytorch
that referenced
this pull request
Dec 21, 2023
…rch#114909) # Summary Users have reported that this warning message leads to confusion about the correctness of the mask even though it is only concerned with performance. Pull Request resolved: pytorch#114909 Approved by: https://github.com/Chillee
dmenig
pushed a commit
to dmenig/pytorch
that referenced
this pull request
Dec 21, 2023
…rch#114909) # Summary Users have reported that this warning message leads to confusion about the correctness of the mask even though it is only concerned with performance. Pull Request resolved: pytorch#114909 Approved by: https://github.com/Chillee
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Users have reported that this warning message leads to confusion about the correctness of the mask even though it is only concerned with performance.