New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dynamo] support `dict.fromkeys()` / `OrderedDict.fromkeys()` / `defaultdict.fromkeys()` #115010

Closed

XuehaiPan wants to merge 9 commits into gh/XuehaiPan/18/base from gh/XuehaiPan/18/head

Collaborator

XuehaiPan commented Dec 2, 2023 •

edited

Stack from ghstack (oldest at bottom):

Add support for dict.fromkeys, OrderedDict.fromkeys, and defaultdict.fromkeys.

[dynamo] missing support for builtin function dict.fromkeys(iterable, value=None, /) #114963

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @aakhundov @kadeng


          [dynamo] support dict.fromkeys

[ghstack-poisoned]

pytorch-bot bot commented Dec 2, 2023 •

edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/115010

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit b115745 with merge base ec124b9 ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

This was referenced Dec 1, 2023

[pytree] traverse dict in sorted key ordering #114947

Draft

[pytree] freeze attributes of TreeSpec #114946

Closed

github-actions bot added module: dynamo ciflow/inductor labels


          Update on "[dynamo] support dict.fromkeys"

1eafeda

Add support for `dict.fromkeys`, `OrderedDict.fromkeys`, and `defaultdict.fromkeys`.

Fixes #114963

- #114963

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng

[ghstack-poisoned]

pytorchbot added the open source label


          Update on "[dynamo] support dict.fromkeys"

2f9e44b

Add support for `dict.fromkeys`, `OrderedDict.fromkeys`, and `defaultdict.fromkeys`.

Fixes #114963

- #114963

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng

[ghstack-poisoned]

XuehaiPan changed the title ~~[dynamo] support dict.fromkeys~~ [dynamo] support dict.fromkeys / OrderedDict.fromkeys / defaultdict.fromkeys

XuehaiPan linked an issue

that may be closed by this pull request

[dynamo] missing support for builtin function dict.fromkeys(iterable, value=None, /) #114963

Closed

XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request


          [dynamo] support dict.fromkeys / OrderedDict.fromkeys / `defaultd…

64ea482

…ict.fromkeys`

ghstack-source-id: ad99357ee42595bd91c5c2c3f0ed6a03d34dff42
Pull Request resolved: pytorch#115010


          Update on "[dynamo] support dict.fromkeys / OrderedDict.fromkeys …

9f35f92

…/ `defaultdict.fromkeys`"


Add support for `dict.fromkeys`, `OrderedDict.fromkeys`, and `defaultdict.fromkeys`.

Fixes #114963

- #114963

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng

[ghstack-poisoned]

This was referenced Dec 2, 2023

[dynamo] support dict.update(seq2) / OrderedDict.update(seq2) / defaultdict.update(seq2) #115011

Closed

[dynamo] support dict.copy() / OrderedDict.copy() / defaultdict.copy() #115012

Closed

XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request


          [dynamo] support dict.fromkeys / OrderedDict.fromkeys / `defaultd…

514ab3f

…ict.fromkeys`

ghstack-source-id: 55ab9a821c6f5f3e6ff30da6b9aa6e15afd8f9c8
Pull Request resolved: pytorch#115010

XuehaiPan added 2 commits

December 2, 2023 20:08


          Update on "[dynamo] support dict.fromkeys / OrderedDict.fromkeys …

798b1c3

…/ `defaultdict.fromkeys`"


Add support for `dict.fromkeys`, `OrderedDict.fromkeys`, and `defaultdict.fromkeys`.

Fixes #114963

- #114963

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng

[ghstack-poisoned]


          Update on "[dynamo] support dict.fromkeys / OrderedDict.fromkeys …

d299325

…/ `defaultdict.fromkeys`"


Add support for `dict.fromkeys`, `OrderedDict.fromkeys`, and `defaultdict.fromkeys`.

Fixes #114963

- #114963

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng

[ghstack-poisoned]

XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request


          [dynamo] support dict.fromkeys / OrderedDict.fromkeys / `defaultd…

fcbae39

…ict.fromkeys`

ghstack-source-id: 1404635354b679161491c647d45d2fa7d376e15a
Pull Request resolved: pytorch#115010


          Update on "[dynamo] support dict.fromkeys / OrderedDict.fromkeys …

b9bb0c7

…/ `defaultdict.fromkeys`"


Add support for `dict.fromkeys`, `OrderedDict.fromkeys`, and `defaultdict.fromkeys`.

Fixes #114963

- #114963

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng

[ghstack-poisoned]

XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request


          [dynamo] support dict.fromkeys / OrderedDict.fromkeys / `defaultd…

a6822a0

…ict.fromkeys`

ghstack-source-id: 4d9351ce7d4999a53231e95107b372bba326dfdf
Pull Request resolved: pytorch#115010


          Update on "[dynamo] support dict.fromkeys / OrderedDict.fromkeys …

ad43a60

…/ `defaultdict.fromkeys`"


Add support for `dict.fromkeys`, `OrderedDict.fromkeys`, and `defaultdict.fromkeys`.

Fixes #114963

- #114963

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng

[ghstack-poisoned]

XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request


          [dynamo] support dict.fromkeys / OrderedDict.fromkeys / `defaultd…

8773d83

…ict.fromkeys`

ghstack-source-id: 7a13db59480b6ba0a669f0b2fb346ea42e8230f4
Pull Request resolved: pytorch#115010


          Update on "[dynamo] support dict.fromkeys / OrderedDict.fromkeys …

b115745

…/ `defaultdict.fromkeys`"


Add support for `dict.fromkeys`, `OrderedDict.fromkeys`, and `defaultdict.fromkeys`.

Fixes #114963

- #114963

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng

[ghstack-poisoned]

XuehaiPan changed the title ~~[dynamo] support dict.fromkeys / OrderedDict.fromkeys / defaultdict.fromkeys~~ [dynamo] support dict.fromkeys() / OrderedDict.fromkeys() / defaultdict.fromkeys()

XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request


          [dynamo] support dict.fromkeys / OrderedDict.fromkeys / `defaultd…

97ff9ae

…ict.fromkeys`

ghstack-source-id: 6433b5def476883ae50d895003a0c164b262fc40
Pull Request resolved: pytorch#115010

XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request


          [dynamo] support dict.fromkeys() / OrderedDict.fromkeys() / `defa…

25a8808

…ultdict.fromkeys()`

ghstack-source-id: 6433b5def476883ae50d895003a0c164b262fc40
Pull Request resolved: pytorch#115010

jansel approved these changes

View reviewed changes

jansel added the release notes: dynamo label

pytorchmergebot added the Merged label

pytorchmergebot closed this in

2e8ac5e

pytorchmergebot pushed a commit that referenced this pull request


          [dynamo] support dict.update(seq2) / OrderedDict.update(seq2) / `…

917a52d

…defaultdict.update(seq2)` (#115011)

Pull Request resolved: #115011
Approved by: https://github.com/jansel
ghstack dependencies: #115010

pytorchmergebot pushed a commit that referenced this pull request


          [dynamo] support dict.copy() / OrderedDict.copy() / `defaultdict.…

3fbfa8c

…copy()` (#115012)

Pull Request resolved: #115012
Approved by: https://github.com/jansel
ghstack dependencies: #115010, #115011

facebook-github-bot deleted the gh/XuehaiPan/18/head branch

December 7, 2023 15:27

hyperfraise pushed a commit to hyperfraise/pytorch that referenced this pull request


          [dynamo] support dict.fromkeys() / OrderedDict.fromkeys() / `defa…

564829a

…ultdict.fromkeys()` (pytorch#115010)

Add support for `dict.fromkeys`, `OrderedDict.fromkeys`, and `defaultdict.fromkeys`.

Fixes pytorch#114963

- pytorch#114963

Pull Request resolved: pytorch#115010
Approved by: https://github.com/jansel

hyperfraise pushed a commit to hyperfraise/pytorch that referenced this pull request


          [dynamo] support dict.update(seq2) / OrderedDict.update(seq2) / `…

4f47207

…defaultdict.update(seq2)` (pytorch#115011)

Pull Request resolved: pytorch#115011
Approved by: https://github.com/jansel
ghstack dependencies: pytorch#115010

hyperfraise pushed a commit to hyperfraise/pytorch that referenced this pull request


          [dynamo] support dict.copy() / OrderedDict.copy() / `defaultdict.…

56487c5

…copy()` (pytorch#115012)

Pull Request resolved: pytorch#115012
Approved by: https://github.com/jansel
ghstack dependencies: pytorch#115010, pytorch#115011

hyperfraise pushed a commit to hyperfraise/pytorch that referenced this pull request


          [dynamo] support dict.fromkeys() / OrderedDict.fromkeys() / `defa…

ab11d29

…ultdict.fromkeys()` (pytorch#115010)

Add support for `dict.fromkeys`, `OrderedDict.fromkeys`, and `defaultdict.fromkeys`.

Fixes pytorch#114963

- pytorch#114963

Pull Request resolved: pytorch#115010
Approved by: https://github.com/jansel

hyperfraise pushed a commit to hyperfraise/pytorch that referenced this pull request


          [dynamo] support dict.update(seq2) / OrderedDict.update(seq2) / `…

455c576

…defaultdict.update(seq2)` (pytorch#115011)

Pull Request resolved: pytorch#115011
Approved by: https://github.com/jansel
ghstack dependencies: pytorch#115010

hyperfraise pushed a commit to hyperfraise/pytorch that referenced this pull request


          [dynamo] support dict.copy() / OrderedDict.copy() / `defaultdict.…

0d7f6e3

…copy()` (pytorch#115012)

Pull Request resolved: pytorch#115012
Approved by: https://github.com/jansel
ghstack dependencies: pytorch#115010, pytorch#115011

ZhiweiYan-96 pushed a commit to ZhiweiYan-96/pytorch that referenced this pull request


          [dynamo] support dict.fromkeys() / OrderedDict.fromkeys() / `defa…

36d9174

…ultdict.fromkeys()` (pytorch#115010)

Add support for `dict.fromkeys`, `OrderedDict.fromkeys`, and `defaultdict.fromkeys`.

Fixes pytorch#114963

- pytorch#114963

Pull Request resolved: pytorch#115010
Approved by: https://github.com/jansel

ZhiweiYan-96 pushed a commit to ZhiweiYan-96/pytorch that referenced this pull request


          [dynamo] support dict.update(seq2) / OrderedDict.update(seq2) / `…

c291441

…defaultdict.update(seq2)` (pytorch#115011)

Pull Request resolved: pytorch#115011
Approved by: https://github.com/jansel
ghstack dependencies: pytorch#115010

ZhiweiYan-96 pushed a commit to ZhiweiYan-96/pytorch that referenced this pull request


          [dynamo] support dict.copy() / OrderedDict.copy() / `defaultdict.…

a04e386

…copy()` (pytorch#115012)

Pull Request resolved: pytorch#115012
Approved by: https://github.com/jansel
ghstack dependencies: pytorch#115010, pytorch#115011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment