[inductor] Fix shape mismatch in sdpa pattern matcher #115038
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #100316 [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/115038
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit f100b3e with merge base 32b928e ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
jansel
added
release notes: inductor
ciflow/trunk
oulgen
approved these changes
Dec 3, 2023
oulgen
reviewed
Dec 3, 2023
| specific_graph = trace_fn(search_fn, args) | ||
| except RuntimeError as e: | ||
| log.info( | ||
| "Replacement pattern %s failed to apply due to shape mismatch: %s", |
There was a problem hiding this comment.
Is shape mismatch the only exception that could be thrown here?
There was a problem hiding this comment.
It should be, since we already passed the shape-agnostic match.
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
hyperfraise
pushed a commit
to hyperfraise/pytorch
that referenced
this pull request
Dec 21, 2023
Fixes pytorch#100316 Pull Request resolved: pytorch#115038 Approved by: https://github.com/oulgen
hyperfraise
pushed a commit
to hyperfraise/pytorch
that referenced
this pull request
Dec 21, 2023
Fixes pytorch#100316 Pull Request resolved: pytorch#115038 Approved by: https://github.com/oulgen
ZhiweiYan-96
pushed a commit
to ZhiweiYan-96/pytorch
that referenced
this pull request
Dec 22, 2023
Fixes pytorch#100316 Pull Request resolved: pytorch#115038 Approved by: https://github.com/oulgen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Fixes #100316
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @peterbell10 @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @aakhundov @ColinPeppler